-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add unified SDK mobile vitals cdocs pages #35860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
969b22a
Migrate mobile vitals pages to unified SDK cdocs format
rtrieu e2d5f5a
Add shared overview partial to mobile vitals shortcodes
rtrieu 6ad8343
update/remove image and navigation
rtrieu 6c1b972
fixes
rtrieu 0f69929
[DOCS-11179] Rearrange track user interactions
rtrieu 83a1756
Revert "[DOCS-11179] Rearrange track user interactions"
rtrieu 63e472f
Merge branch 'master' into rtrieu/mobile-vitals-cdocs-migration
rtrieu 05ad9fd
correct and add links per dom comments
rtrieu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --- | ||
| title: Mobile Vitals | ||
| content_filters: | ||
| - trait_id: platform | ||
| option_group_id: client_sdk_mobile_platform_options | ||
| label: "SDK" | ||
| --- | ||
|
|
||
| <!-- Android --> | ||
| {% if equals($platform, "android") %} | ||
| {% partial file="sdk/mobile_vitals/android.mdoc.md" /%} | ||
| {% /if %} | ||
|
|
||
| <!-- iOS --> | ||
| {% if equals($platform, "ios") %} | ||
| {% partial file="sdk/mobile_vitals/ios.mdoc.md" /%} | ||
| {% /if %} | ||
|
|
||
| <!-- Flutter --> | ||
| {% if equals($platform, "flutter") %} | ||
| {% partial file="sdk/mobile_vitals/flutter.mdoc.md" /%} | ||
| {% /if %} | ||
|
|
||
| <!-- React Native --> | ||
| {% if equals($platform, "react_native") %} | ||
| {% partial file="sdk/mobile_vitals/react_native.mdoc.md" /%} | ||
| {% /if %} | ||
|
|
||
| <!-- Kotlin Multiplatform --> | ||
| {% if equals($platform, "kotlin_multiplatform") %} | ||
| {% partial file="sdk/mobile_vitals/kotlin_multiplatform.mdoc.md" /%} | ||
| {% /if %} | ||
|
|
||
| <!-- Unity --> | ||
| {% if equals($platform, "unity") %} | ||
| {% partial file="sdk/mobile_vitals/unity.mdoc.md" /%} | ||
| {% /if %} |
8 changes: 0 additions & 8 deletions
8
content/en/real_user_monitoring/application_monitoring/android/mobile_vitals.md
This file was deleted.
Oops, something went wrong.
16 changes: 16 additions & 0 deletions
16
...nt/en/real_user_monitoring/application_monitoring/android/mobile_vitals.mdoc.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| title: Android Mobile Vitals | ||
| description: "Monitor Android mobile vitals including startup times, resource usage, and performance metrics to optimize app performance and user experience." | ||
| aliases: | ||
| - /real_user_monitoring/android/mobile_vitals | ||
| - /real_user_monitoring/mobile_and_tv_monitoring/android/mobile_vitals | ||
| - /real_user_monitoring/application_monitoring/mobile_vitals | ||
| further_reading: | ||
| - link: https://github.com/DataDog/dd-sdk-android | ||
| tag: "Source Code" | ||
| text: Source code for dd-sdk-android | ||
| - link: /real_user_monitoring | ||
| tag: Documentation | ||
| text: Explore Datadog RUM | ||
| --- | ||
| {% partial file="sdk/mobile_vitals/android.mdoc.md" /%} |
8 changes: 0 additions & 8 deletions
8
content/en/real_user_monitoring/application_monitoring/flutter/mobile_vitals.md
This file was deleted.
Oops, something went wrong.
15 changes: 15 additions & 0 deletions
15
...nt/en/real_user_monitoring/application_monitoring/flutter/mobile_vitals.mdoc.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| title: Flutter Mobile Vitals | ||
| description: "Track Flutter mobile vitals including performance metrics, startup times, and resource usage for iOS and Android platforms." | ||
| aliases: | ||
| - /real_user_monitoring/flutter/mobile_vitals | ||
| - /real_user_monitoring/mobile_and_tv_monitoring/flutter/mobile_vitals | ||
| further_reading: | ||
| - link: https://github.com/DataDog/dd-sdk-flutter | ||
| tag: "Source Code" | ||
| text: Source code for dd-sdk-flutter | ||
| - link: /real_user_monitoring | ||
| tag: Documentation | ||
| text: Explore Datadog RUM | ||
| --- | ||
| {% partial file="sdk/mobile_vitals/flutter.mdoc.md" /%} |
8 changes: 0 additions & 8 deletions
8
content/en/real_user_monitoring/application_monitoring/ios/mobile_vitals.md
This file was deleted.
Oops, something went wrong.
15 changes: 15 additions & 0 deletions
15
content/en/real_user_monitoring/application_monitoring/ios/mobile_vitals.mdoc.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| title: iOS Mobile Vitals | ||
| description: "Monitor iOS mobile vitals including performance metrics, startup times, and resource usage to optimize app performance and user experience." | ||
| aliases: | ||
| - /real_user_monitoring/ios/mobile_vitals | ||
| - /real_user_monitoring/mobile_and_tv_monitoring/ios/mobile_vitals | ||
| further_reading: | ||
| - link: https://github.com/DataDog/dd-sdk-ios | ||
| tag: "Source Code" | ||
| text: Source code for dd-sdk-ios | ||
| - link: /real_user_monitoring | ||
| tag: Documentation | ||
| text: Explore Datadog RUM | ||
| --- | ||
| {% partial file="sdk/mobile_vitals/ios.mdoc.md" /%} |
8 changes: 0 additions & 8 deletions
8
...al_user_monitoring/application_monitoring/kotlin_multiplatform/mobile_vitals.md
This file was deleted.
Oops, something went wrong.
14 changes: 14 additions & 0 deletions
14
...er_monitoring/application_monitoring/kotlin_multiplatform/mobile_vitals.mdoc.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| title: Kotlin Multiplatform Mobile Vitals | ||
| description: "Monitor mobile vitals for Kotlin Multiplatform applications including performance metrics across iOS and Android platforms." | ||
| aliases: | ||
| - /real_user_monitoring/mobile_and_tv_monitoring/kotlin_multiplatform/mobile_vitals | ||
| further_reading: | ||
| - link: https://github.com/DataDog/dd-sdk-kotlin-multiplatform | ||
| tag: "Source Code" | ||
| text: Source code for dd-sdk-kotlin-multiplatform | ||
| - link: /real_user_monitoring | ||
| tag: Documentation | ||
| text: Explore Datadog RUM | ||
| --- | ||
| {% partial file="sdk/mobile_vitals/kotlin_multiplatform.mdoc.md" /%} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rtrieu I'm assuming this will be uncommented out once everything is converted over?
Also, can you confirm my mental map of how you're approaching this?
It seems that you are migrating content over to fit under the Client SDKs parent. You're doing this piecemeal, so the Client SDKs page is not public yet -- users will continue to navigate the Mobile Vitals docs as they have until now. However, you're creating all the scaffolding (partials and such) such that once all the mdoc files you need are created, you can "flip the switch" essentially and remove the old RUM files and go live with all the new stuff. Does my explanation make sense and does it align with how you're approaching this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi dom, yes, exactly!
doing this all in one PR would've been unwieldy, and chaining each PR on unmerged branches would've created too many merge conflicts, so i did it topic-by-topic against master so that things would be clean.