-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[FFL-917] Add documentation for the Flags SDK for React Native #34355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
|
Editorial Review Jira ticket: https://datadoghq.atlassian.net/browse/DOCS-13324 |
| @@ -0,0 +1,484 @@ | |||
| --- | |||
| title: React Native Feature Flags | |||
| description: Set up Datadog Feature Flags for React Native applications. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other sdks have:
aliases:
- /feature_flags/setup/ios/
is that needed or redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it's not needed as this is a brand new page and doesn't need any redirects (that are defined by alias)?
Will add it for consistency with other platforms, though
| {{< tabs >}} | ||
| {{% tab "npm" %}} | ||
| {{< code-block lang="bash" >}} | ||
| npm install @datadog/mobile-react-native @datadog/mobile-react-native-openfeature @openfeature/react-sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is @openfeature/core needed?
| const config = new DatadogProviderConfiguration( | ||
| '<CLIENT_TOKEN>', | ||
| '<ENVIRONMENT_NAME>', | ||
| trackingConsent, | ||
| { | ||
| rumConfiguration: { | ||
| applicationId: '<APPLICATION_ID>', | ||
| }, | ||
| // ... | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double check your constructor order arguments here, they are different than the usage of DatadogProviderConfiguration above
What does this PR do? What is the motivation?
This is the documentation PR for the Feature Flags SDK release for React Native.
Related ticket: https://datadoghq.atlassian.net/browse/FFL-917
Merge instructions
Note: This PR depends on this PR in the React Native SDK repo: DataDog/dd-sdk-reactnative#1092. We can merge this documentation PR once those changes are released to the public.
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes