Unify test frameworks. Step 01 Laravel8 - #4149
Conversation
|
Benchmarks [ tracer ]Benchmark execution time: 2026-08-31 17:04:57 Comparing candidate commit 5f52e5f in PR branch Found 2 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 0 unstable metrics.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Why this PR exists
Now when we add appsec coverage to a new framework, we maintain two separate copies of it:
This made sense historically but we are in the same repository now moving into a more unified experience.
Due to this duplication, whenever we have to test something in addition to duplicate the framework, we have to duplicate the endpoints. Like it happened with all authentication features.
The proposal
Retire the appsec-side duplicates and point the appsec integration test container at the canonical copy under
tests/Frameworks/. Any routes or fixtures that appsec tests need get added directly to the shared framework. The tracer tests don't care about the extra routes, and appsec gets a richer, always-current environment for free.This PR: Laravel 8x as the first step
appsec/tests/integration/src/test/www/laravel8x/copytests/Frameworks/Laravel/Version_8_x/Laravel8xTests.groovyto mount the shared path and target PHP 8.1 (matching the version the tracer already tests against)test_web_laravel_8x jobsand all appsec integration test jobs passNext steps
Not doing
Reviewer checklist