fix: support stable OTel deployment environment - #4148
Conversation
|
Benchmarks [ tracer ]Benchmark execution time: 2026-08-28 16:56:46 Comparing candidate commit 0d2e8c6 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.
|
bwoebi
left a comment
There was a problem hiding this comment.
Thanks for also fixing the off-by-one bug in the loop with multiple valid otel attributes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d2e8c6cee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
Map the stable OpenTelemetry resource attribute
deployment.environment.nametoDD_ENV. Keepdeployment.environmentas a fallback andDD_ENVas the highest-precedence source.The scanner records stable and legacy values separately so attribute order does not change the result. It consumes both environment aliases, keeps unrelated attributes, and handles the stable attribute when it is the final entry.
Related PRs:
All five focused PHPTs passed in
datadog/dd-trace-ci:php-8.3_bookworm-10.Reviewer checklist