Skip to content

libdatadog update to 9fb27ea3 - #4125

Open
dd-octo-sts[bot] wants to merge 2 commits into
masterfrom
bot/libdatadog-latest
Open

libdatadog update to 9fb27ea3#4125
dd-octo-sts[bot] wants to merge 2 commits into
masterfrom
bot/libdatadog-latest

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Automated update of the libdatadog submodule to the latest HEAD.

SHA
Previous $LIBDATADOG_PINNED_SHA
New 9fb27ea309363bb4852d093a8e5c85b1c0b9a7d0

Full CI result: ❌ 175 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/134211239


(Claude did not produce a report — see tmp/artifacts/claude_output.txt in the CI pipeline.)


/cc @bwoebi

@dd-octo-sts
dd-octo-sts Bot requested review from a team as code owners August 21, 2026 12:05
@dd-octo-sts
dd-octo-sts Bot requested review from btthomas and leoromanovsky and removed request for a team August 21, 2026 12:05
@github-actions github-actions Bot added profiling Relates to the Continuous Profiler tracing area:asm labels Aug 21, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 21, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 79 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | System Tests: [APPSEC_API_SECURITY] — ❌ 10 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

❌ tests.appsec.api_security.test_schemas.Test_Scanners.test_request_method[apache-mod-8.0] from system_tests_suite
assert None

self = <tests.appsec.api_security.test_schemas.Test_Scanners object at 0x7febf64a2870>

    def test_request_method(self):
        """Can provide request header schema"""
        schema_cookies = get_schema(self.request, "req.cookies")
        schema_headers = get_schema(self.request, "req.headers")
        assert self.request.status_code == 200
>       assert schema_cookies
...
❌ tests.appsec.api_security.test_schemas.Test_Schema_Request_Cookies.test_request_method[apache-mod-8.0] from system_tests_suite
assert None

self = <tests.appsec.api_security.test_schemas.Test_Schema_Request_Cookies object at 0x7febf64a2e10>

    def test_request_method(self):
        """Can provide request header schema"""
        schema = get_schema(self.request, "req.cookies")
        assert self.request.status_code == 200
>       assert schema
E       assert None
...
❌ tests.appsec.api_security.test_schemas.Test_Schema_Request_FormUrlEncoded_Body.test_request_method[apache-mod-8.0] from system_tests_suite
AssertionError: None
assert (False or False or False)
 +  where False = contains(None, [{'main': [[[{'key': [...], 'value': [...]}]], {'len': 2}], 'nullable': [8]}])
 +  and   False = contains(None, [{'main': [[[{'key': [...], 'value': [...]}]], {'len': 2}], 'nullable': [1]}])
 +  and   False = contains(None, [{'main[0][key]': Ellipsis, 'main[0][value]': Ellipsis, 'main[1][key]': Ellipsis, 'main[1][value]': Ellipsis}])

self = <tests.appsec.api_security.test_schemas.Test_Schema_Request_FormUrlEncoded_Body object at 0x7febf64a3380>

    def test_request_method(self):
        """Can provide request request body schema"""
...
↳ and 7 more — View all
DataDog/apm-reliability/dd-trace-php | System Tests: [APPSEC_API_SECURITY_NO_RESPONSE_BODY] — ❌ 1 test failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

❌ tests.appsec.api_security.test_schemas.Test_Schema_Response_Body_env_var.test_request_method[apache-mod-8.0] from system_tests_suite
assert False
 +  where False = isinstance(None, list)

self = <tests.appsec.api_security.test_schemas.Test_Schema_Response_Body_env_var object at 0x7f9d6cc5abd0>

    def test_request_method(self):
        """Can provide response body schema"""
        assert self.request.status_code == 200
    
        headers_schema = get_schema(self.request, "res.headers")
...
DataDog/apm-reliability/dd-trace-php | System Tests: [APPSEC_API_SECURITY_RC] — ❌ 13 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

❌ tests.appsec.api_security.test_api_security_rc.Test_API_Security_RC_ASM_DD_processors.test_request_method[apache-mod-8.0] from system_tests_suite
assert None

self = <tests.appsec.api_security.test_api_security_rc.Test_API_Security_RC_ASM_DD_processors object at 0x7f2ffbef6ab0>

    def test_request_method(self):
        """Can provide custom req.querytest schema"""
        schema = get_schema(self.request, "req.querytest")
        assert self.request.status_code == 200
>       assert schema
E       assert None
...
❌ tests.appsec.api_security.test_api_security_rc.Test_API_Security_RC_ASM_DD_scanners.test_request_method[apache-mod-8.0] from system_tests_suite
assert None

self = <tests.appsec.api_security.test_api_security_rc.Test_API_Security_RC_ASM_DD_scanners object at 0x7f2ffbef76b0>

    def test_request_method(self):
        """Can provide custom req.querytest schema"""
        schema = get_schema(self.request, "req.bodytest")
        expected_mail_schema = [8, {"category": "pii", "type": "email"}]
    
        assert self.request.status_code == 200
...
❌ tests.appsec.api_security.test_custom_data_classification.Test_API_Security_Custom_Data_Classification_Multiple_Scanners.test_request_method[apache-mod-8.0] from system_tests_suite
AssertionError: Schema should be present in the span
assert None is not None

self = <tests.appsec.api_security.test_custom_data_classification.Test_API_Security_Custom_Data_Classification_Multiple_Scanners object at 0x7f2ffb765a00>

    def test_request_method(self):
        """Verify both standard and custom scanners detect their respective data"""
        schema = get_schema(self.request, "req.bodytest")
        assert self.request.status_code == 200
>       assert schema is not None, "Schema should be present in the span"
...
↳ and 10 more — View all

View all 79 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 53.54% (-7.12%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 316187d | Docs | View more details | Give us feedback!

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 378be45c libdatadog update to 9d6b2ffb Aug 22, 2026
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch 2 times, most recently from 1571744 to 3fb3c5e Compare August 23, 2026 07:18
@dd-octo-sts
dd-octo-sts Bot requested review from a team as code owners August 23, 2026 07:18
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 4cab22f to a71405a Compare August 24, 2026 11:21
@pr-commenter

pr-commenter Bot commented Aug 24, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-08-31 04:42:48

Comparing candidate commit 316187d in PR branch bot/libdatadog-latest with baseline commit f4c0c7e in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 193 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-5.676µs; -4.864µs] or [-4.932%; -4.226%]

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 9d6b2ffb libdatadog update to 966f921c Aug 25, 2026
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 751e928 to 958e666 Compare August 25, 2026 05:47
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner August 25, 2026 05:47
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 966f921c libdatadog update to 7d138079 Aug 26, 2026
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 76428f6 to ae07652 Compare August 26, 2026 02:46
@cataphract

Copy link
Copy Markdown
Contributor

Blocked by #3725

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 7d138079 libdatadog update to 4cfd390c Aug 27, 2026
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch 2 times, most recently from b38fd2d to 29bfb62 Compare August 28, 2026 02:47
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 4cfd390c libdatadog update to 7327f304 Aug 28, 2026
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 7327f304 libdatadog update to 9fb27ea3 Aug 29, 2026
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from b906c05 to 63b912d Compare August 29, 2026 02:49
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 1ec72a5 to 019f0ff Compare August 30, 2026 02:38
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from c43dbd0 to 45e028c Compare August 31, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:asm profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants