Skip to content

feat(openfeature): emit server-side EVP flagevaluation #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leoromanovsky wants to merge 10 commits into
base: master
Choose a base branch
from
+1,273 −12
Draft

feat(openfeature): emit server-side EVP flagevaluation #3984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6bdbf7b
chore(02-07): enable flagevaluation-evp feature + fix VecMap compat w…
leoromanovsky Jun 12, 2026
343e2cb
feat(02-07): add EVP flagevaluation aggregation + RSHUTDOWN flush dis…
leoromanovsky Jun 12, 2026
22f9031
fix(02-07): add EVP_TEST_LOCK to empty_targeting_key test to prevent …
leoromanovsky Jun 12, 2026
19818e1
build(02-07): bump libdatadog submodule to PREP-01 commit (89a2ba7fc)…
leoromanovsky Jun 12, 2026
9dc928e
fix(02-07): declare ddog_ffe_flush_flag_evaluation_batch in datadog.h
leoromanovsky Jun 12, 2026
59136c5
fix(openfeature): prune full-tier context and surface degraded-overfl…
leoromanovsky Jun 13, 2026
1473e62
test(openfeature): cover EVP FFI emission, context pruning, and overf…
leoromanovsky Jun 13, 2026
862b74d
chore(openfeature): remove internal planning annotations
leoromanovsky Jun 13, 2026
63fdebe
chore(openfeature): wire flagevaluation benchmark into benchmark suite
leoromanovsky Jun 13, 2026
f5e4087
fix(openfeature): deliver EVP flagevaluation batch to the sidecar (bi…
leoromanovsky Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components-rs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ libdd-telemetry-ffi = { path = "../libdatadog/libdd-telemetry-ffi", default-feat
datadog-live-debugger = { path = "../libdatadog/datadog-live-debugger" }
datadog-live-debugger-ffi = { path = "../libdatadog/datadog-live-debugger-ffi", default-features = false }
datadog-ipc = { path = "../libdatadog/datadog-ipc" }
datadog-ffe = { path = "../libdatadog/datadog-ffe" }
datadog-ffe = { path = "../libdatadog/datadog-ffe", features = ["flagevaluation-evp"] }
libdd-remote-config = { path = "../libdatadog/libdd-remote-config" }
datadog-sidecar = { path = "../libdatadog/datadog-sidecar" }
datadog-sidecar-ffi = { path = "../libdatadog/datadog-sidecar-ffi" }
Expand Down
8 changes: 4 additions & 4 deletions components-rs/bytes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,12 @@ pub extern "C" fn ddog_add_str_span_meta_CharSlice(

#[no_mangle]
pub extern "C" fn ddog_del_span_meta_zstr(ptr: &mut SpanBytes, key: &mut ZendString) {
ptr.meta.remove(&convert_zend_to_bytes_string(key));
ptr.meta.remove_slow(&convert_zend_to_bytes_string(key));
}

#[no_mangle]
pub extern "C" fn ddog_del_span_meta_str(ptr: &mut SpanBytes, key: *const c_char) {
ptr.meta.remove(&convert_literal_to_bytes_string(key));
ptr.meta.remove_slow(&convert_literal_to_bytes_string(key));
}

#[no_mangle]
Expand Down Expand Up @@ -290,7 +290,7 @@ pub extern "C" fn ddog_has_span_metrics_zstr(ptr: &mut SpanBytes, key: &mut Zend

#[no_mangle]
pub extern "C" fn ddog_del_span_metrics_zstr(ptr: &mut SpanBytes, key: &mut ZendString) {
ptr.metrics.remove(&convert_zend_to_bytes_string(key));
ptr.metrics.remove_slow(&convert_zend_to_bytes_string(key));
}

#[no_mangle]
Expand All @@ -316,7 +316,7 @@ pub extern "C" fn ddog_get_span_metrics_str(

#[no_mangle]
pub extern "C" fn ddog_del_span_metrics_str(ptr: &mut SpanBytes, key: *const c_char) {
ptr.metrics.remove(&convert_literal_to_bytes_string(key));
ptr.metrics.remove_slow(&convert_literal_to_bytes_string(key));
}

#[no_mangle]
Expand Down
7 changes: 7 additions & 0 deletions components-rs/datadog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,13 @@ struct ddog_FfeResult ddog_ffe_evaluate(ddog_CharSlice flag_key,
const struct ddog_FfeAttribute *attributes,
uintptr_t attributes_count);

bool ddog_ffe_flush_flag_evaluation_batch(struct ddog_SidecarTransport **transport,
const struct ddog_InstanceId *instance_id,
const ddog_QueueId *queue_id,
ddog_CharSlice service,
ddog_CharSlice env,
ddog_CharSlice version);

bool ddog_shall_log(enum ddog_Log category);

void ddog_set_error_log_level(bool once);
Expand Down
Loading