Add telemetry metrics for dropped/skipped events - #12319
Conversation
when snapshots are dropped (Queue full) or skipped (rate limit or eval timeout) we are sending telemetry metrics with te number of events (snapshots) involved. metrics are tagged by reason we are removing the old DebuggerMetrics and the skip cause to replace by this new telemetry metrics. More telemetry metrics will be added later
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 560d92d527
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
The metric collector can lose event counts during a concurrent reset. Some timeout and disabled-session paths also omit or use an incorrect skip reason.
🤖 Datadog Autotest · Commit 560d92d · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 288b633 | Docs | View more details | Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (400.79 µs) : 345, 456
. : milestone, 401,
basic (347.473 µs) : 342, 353
. : milestone, 347,
loop (8.121 ms) : 8057, 8185
. : milestone, 8121,
section candidate
noprobe (378.732 µs) : 326, 431
. : milestone, 379,
basic (341.821 µs) : 333, 351
. : milestone, 342,
loop (8.115 ms) : 8052, 8179
. : milestone, 8115,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
sarahchen6
left a comment
There was a problem hiding this comment.
Looks like Jacoco is complaining about test coverage, but otherwise LGTM
make INSTANCE private
What Does This Do
when snapshots are dropped (Queue full) or skipped (rate limit or eval timeout) we are sending telemetry metrics with te number of events (snapshots) involved. metrics are tagged by reason
we are removing the old DebuggerMetrics and the skip cause to replace by this new telemetry metrics.
More telemetry metrics will be added later
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5839