Add test reporting for Karate v2#11923
Conversation
4d2d28e to
1d0e84d
Compare
Test Environment - sbt-scalatestJob Status: 🟢 success
Baseline: median of |
Test Environment - reactive-streams-jvmJob Status: 🟢 success
Baseline: median of |
Test Environment - nebula-release-pluginJob Status: 🟢 success
Baseline: median of |
Test Environment - pass4sJob Status: 🟢 success
Baseline: median of |
Test Environment - heliboardJob Status: 🟢 success
Baseline: median of |
Test Environment - sonar-kotlinJob Status: 🟢 success
Baseline: median of |
|
🎯 Code Coverage (details) 🔗 Commit SHA: e459f4b | Docs | Datadog PR Page | Give us feedback! |
Test Environment - jolokiaJob Status: 🟢 success
Baseline: median of |
Test Environment - netflix-zuulJob Status: 🟢 success
Baseline: median of |
Test Environment - okhttpJob Status: 🟢 success
Baseline: median of |
Test Environment - spring_bootJob Status: 🟢 success
Baseline: median of |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
1d0e84d to
e7ddda7
Compare
Test Environment - sonar-javaJob Status: 🟢 success
Baseline: median of |
36148cd to
294d720
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2599ffbfcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2599ffb to
cbdc3d4
Compare
cbdc3d4 to
e459f4b
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e459f4bc8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
More details
The karate-2.0 instrumentation is behaviourally correct for its stated scope (basic test reporting + ITR skipping). The most non-obvious risk — that SCENARIO_EXIT fires even when the listener vetoes SCENARIO_ENTER — was confirmed safe: Karate v2 populates the result with skipped-step entries, so afterScenario does not spuriously call onTestSkip, and the unconditional onTestFinish call is a no-op because onTestIgnore already removed the test from inProgressTests. Tag names are stored without the @ prefix, confirming the datadog_itr_unskippable guard works correctly.
📊 Validated against 4 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit e459f4b · What is Autotest? · Any feedback? Reach out in #autotest
What Does This Do
karate-2.0instrumentation module to implement test visibility for Karate 2.0+.karate-1.0module.Motivation
Karate v2 is a complete ground-up rewrite of the framework. Because of this, the original
karate-1.0module cannot instrument it.Additional Notes
A following PR will contain the changes regarding execution instrumentation for Karate v2.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-3816