-
Notifications
You must be signed in to change notification settings - Fork 344
Add Kotlin exploration tests #11921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Kotlin exploration tests #11921
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ COPY .sdkmanrc . | |
| RUN curl -s "https://get.sdkman.io" | bash | ||
| RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && \ | ||
| sdk env install && \ | ||
| sdk install java 17.0.10-tem && \ | ||
| sdk flush" | ||
|
|
||
| RUN mkdir exploration-tests | ||
|
|
@@ -30,7 +31,7 @@ RUN cd jackson-core && git apply /exploration-tests/jackson-core_exploration-tes | |
| RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && cd jackson-core && mvn verify -DskipTests=true" | ||
| RUN git clone -b 2.16 https://github.com/FasterXML/jackson-databind.git | ||
| COPY jackson-databind_exploration-tests.patch . | ||
| # fix tests that are failing because too deep recrursion | ||
| # fix tests that are failing because too deep recursion | ||
| RUN cd jackson-databind && git apply /exploration-tests/jackson-databind_exploration-tests.patch | ||
| RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && cd jackson-databind && mvn verify -DskipTests=true" | ||
|
|
||
|
|
@@ -42,3 +43,8 @@ RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && cd jackson-databind && m | |
| #RUN git clone https://github.com/google/guava.git | ||
| #RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && cd guava && mvn -B -P!standard-with-extra-repos verify -U -Dmaven.javadoc.skip=true -DskipTests=true" | ||
|
|
||
| # okhttp | ||
| RUN git clone -b okhttp_5.3.x https://github.com/square/okhttp.git | ||
| COPY okhttp_exploration-tests.patch . | ||
| RUN cd okhttp && git apply /exploration-tests/okhttp_exploration-tests.patch | ||
| RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && sdk use java 17.0.10-tem && cd okhttp && ./gradlew dependencies" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The image now configures the cloned OkHttp Gradle build, but this Debian image only installs JDKs/Maven and never provides Useful? React with 👍 / 👎. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| okhttp3/* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| diff --git a/okhttp/src/jvmTest/kotlin/okhttp3/FastFallbackTest.kt b/okhttp/src/jvmTest/kotlin/okhttp3/FastFallbackTest.kt | ||
| index e50aa9820..f36561b03 100644 | ||
| --- a/okhttp/src/jvmTest/kotlin/okhttp3/FastFallbackTest.kt | ||
| +++ b/okhttp/src/jvmTest/kotlin/okhttp3/FastFallbackTest.kt | ||
| @@ -38,6 +38,7 @@ import okhttp3.internal.http2.ErrorCode | ||
| import okhttp3.testing.Flaky | ||
| import org.junit.jupiter.api.AfterEach | ||
| import org.junit.jupiter.api.BeforeEach | ||
| +import org.junit.jupiter.api.Disabled | ||
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.Timeout | ||
| import org.junit.jupiter.api.extension.RegisterExtension | ||
| @@ -55,6 +56,7 @@ import org.opentest4j.TestAbortedException | ||
| * This test only runs on host machines that have both IPv4 and IPv6 addresses for localhost. | ||
| */ | ||
| @Timeout(30) | ||
| +@Disabled | ||
| class FastFallbackTest { | ||
| @RegisterExtension | ||
| val clientTestRule = OkHttpClientTestRule() | ||
| diff --git a/okhttp/src/jvmTest/kotlin/okhttp3/InterceptorTest.kt b/okhttp/src/jvmTest/kotlin/okhttp3/InterceptorTest.kt | ||
| index 22f1ceaf5..3df72113b 100644 | ||
| --- a/okhttp/src/jvmTest/kotlin/okhttp3/InterceptorTest.kt | ||
| +++ b/okhttp/src/jvmTest/kotlin/okhttp3/InterceptorTest.kt | ||
| @@ -50,6 +50,7 @@ import okio.GzipSink | ||
| import okio.Sink | ||
| import okio.Source | ||
| import okio.buffer | ||
| +import org.junit.jupiter.api.Disabled | ||
| import org.junit.jupiter.api.Tag | ||
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.extension.RegisterExtension | ||
| @@ -608,11 +609,13 @@ class InterceptorTest { | ||
| ) | ||
| } | ||
|
|
||
| + @Disabled | ||
| @Test | ||
| fun applicationInterceptorThrowsRuntimeExceptionAsynchronous() { | ||
| interceptorThrowsRuntimeExceptionAsynchronous(false) | ||
| } | ||
|
|
||
| + @Disabled | ||
| @Test | ||
| fun networkInterceptorThrowsRuntimeExceptionAsynchronous() { | ||
| interceptorThrowsRuntimeExceptionAsynchronous(true) | ||
| diff --git a/okhttp/src/jvmTest/kotlin/okhttp3/internal/tls/ClientAuthTest.kt b/okhttp/src/jvmTest/kotlin/okhttp3/internal/tls/ClientAuthTest.kt | ||
| index d78fd43e1..5a3429050 100644 | ||
| --- a/okhttp/src/jvmTest/kotlin/okhttp3/internal/tls/ClientAuthTest.kt | ||
| +++ b/okhttp/src/jvmTest/kotlin/okhttp3/internal/tls/ClientAuthTest.kt | ||
| @@ -57,6 +57,7 @@ import okhttp3.tls.HeldCertificate | ||
| import okhttp3.tls.internal.TlsUtil.newKeyManager | ||
| import okhttp3.tls.internal.TlsUtil.newTrustManager | ||
| import org.junit.jupiter.api.BeforeEach | ||
| +import org.junit.jupiter.api.Disabled | ||
| import org.junit.jupiter.api.Tag | ||
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.extension.RegisterExtension | ||
| @@ -310,6 +311,7 @@ class ClientAuthTest { | ||
| } | ||
| } | ||
|
|
||
| + @Disabled | ||
| @Test | ||
| fun invalidClientAuthEvents() { | ||
| server.enqueue( | ||
| diff --git a/okhttp/src/jvmTest/kotlin/okhttp3/internal/ws/WebSocketReaderTest.kt b/okhttp/src/jvmTest/kotlin/okhttp3/internal/ws/WebSocketReaderTest.kt | ||
| index d3f264333..22d709282 100644 | ||
| --- a/okhttp/src/jvmTest/kotlin/okhttp3/internal/ws/WebSocketReaderTest.kt | ||
| +++ b/okhttp/src/jvmTest/kotlin/okhttp3/internal/ws/WebSocketReaderTest.kt | ||
| @@ -32,6 +32,7 @@ import okio.ByteString.Companion.decodeHex | ||
| import okio.ByteString.Companion.encodeUtf8 | ||
| import okio.ByteString.Companion.toByteString | ||
| import org.junit.jupiter.api.AfterEach | ||
| +import org.junit.jupiter.api.Disabled | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class WebSocketReaderTest { | ||
| @@ -431,6 +432,7 @@ class WebSocketReaderTest { | ||
| assertThat(count).isEqualTo(1988) | ||
| } | ||
|
|
||
| + @Disabled | ||
| @Test fun clientWithCompressionCannotBeUsedAfterClose() { | ||
| data.write("c107f248cdc9c90700".decodeHex()) // Hello | ||
| clientReaderWithCompression.processNextFrame() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In merge-request pipelines that touch
dd-java-agent/agent-debugger, this new job inherits the commonchangesrule and runs automatically, but the only step that creates/exploration-tests/okhttpis inDockerfile.exploration-testsandbuild-exploration-tests-imageis stillwhen: manualwith noneedsedge. The first automatic run of this change will therefore use the already-published$EXPLORATION_TESTS_IMAGEwithout an OkHttp checkout, causingrun-exploration-tests.shto fail atcd $PROJECT; keep the job manual until the image is published or wire it to an image built in the same pipeline.Useful? React with 👍 / 👎.