Skip to content

Add VisibleForTesting annotation#11473

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/visible-for-testing-annotation
May 28, 2026
Merged

Add VisibleForTesting annotation#11473
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/visible-for-testing-annotation

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented May 27, 2026

What Does This Do

Adds a shared @VisibleForTesting annotation in components:annotations, exposes it through internal-api, and replaces testing-visibility comments on loosened members.

Motivation

Make testing-only visibility explicit and reusable across modules.

Additional Notes

Validated with spotlessApply and focused compile tasks.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 added comp: tooling Build & Tooling type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels May 27, 2026 — with ChatGPT Codex Connector
@bric3 bric3 requested a review from jpbempel May 27, 2026 16:17
@bric3 bric3 marked this pull request as ready for review May 27, 2026 16:17
@bric3 bric3 requested review from a team as code owners May 27, 2026 16:17
@bric3 bric3 requested review from ValentinZakharov, amarziali and mcculls and removed request for a team May 27, 2026 16:17
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left 2 minor nit comments.
Also worth to announce this annotation to the team in order they start using it.
Also, probably, make sense to update techdebt skill to make Claude to check for this annotation usages.

Comment thread settings.gradle.kts Outdated
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 27, 2026

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1779952367 1779952718
end_time 2026-05-28T07:14:14 2026-05-28T07:20:04
git_branch master bdu/visible-for-testing-annotation
git_commit_sha 56c6e87 da3237c
start_time 2026-05-28T07:12:48 2026-05-28T07:18:39
See matching parameters
Baseline Candidate
ci_job_id 1719142861 1719142861
ci_pipeline_id 115554939 115554939
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1779951792 1779951792

Summary

Found 8 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic better
[-16.700µs; -10.240µs] or [-5.989%; -3.672%]
better
[-21.131µs; -6.788µs] or [-6.765%; -2.173%]
better
[-21.154µs; -6.034µs] or [-6.549%; -1.868%]
unstable
[+167.945µs; +362.522µs] or [+17.015%; +36.729%]
unstable
[-6.558op/s; +244.654op/s] or [-0.275%; +10.275%]
scenario:loop better
[-295.483µs; -148.874µs] or [-3.241%; -1.633%]
better
[-295.492µs; -144.399µs] or [-3.210%; -1.569%]
better
[-304.242µs; -157.611µs] or [-3.275%; -1.697%]
better
[-303.510µs; -135.196µs] or [-3.223%; -1.436%]
better
[+1.590op/s; +4.286op/s] or [+1.487%; +4.007%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-38.415µs; +18.326µs] or [-12.681%; +6.049%]
unstable
[-57.796µs; +20.694µs] or [-16.499%; +5.907%]
unstable
[-71.884µs; +27.162µs] or [-19.487%; +7.363%]
unstable
[+80.795µs; +296.231µs] or [+6.824%; +25.021%]
same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (350.309 µs) : 303, 398
.   : milestone, 350,
basic (312.366 µs) : 305, 319
.   : milestone, 312,
loop (9.206 ms) : 9107, 9305
.   : milestone, 9206,
section candidate
noprobe (331.758 µs) : 309, 354
.   : milestone, 332,
basic (298.407 µs) : 291, 305
.   : milestone, 298,
loop (8.986 ms) : 8981, 8991
.   : milestone, 8986,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 350.309 µs [302.679 µs, 397.939 µs]
basic 312.366 µs [305.359 µs, 319.373 µs]
loop 9.206 ms [9.107 ms, 9.305 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 331.758 µs [309.092 µs, 354.423 µs]
basic 298.407 µs [291.419 µs, 305.394 µs]
loop 8.986 ms [8.981 ms, 8.991 ms]

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 27, 2026

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Startup Time

Scenario This PR master Change
insecure-bank / iast 14,743 ms 14,751 ms -0.1%
insecure-bank / tracing 13,530 ms 13,675 ms -1.1%
petclinic / appsec 16,613 ms 16,501 ms +0.7%
petclinic / iast 16,635 ms 16,591 ms +0.3%
petclinic / profiling 16,508 ms 16,553 ms -0.3%
petclinic / tracing 16,049 ms 16,015 ms +0.2%

Commit: da3237c5 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Comment thread dd-java-agent/build.gradle
@bric3 bric3 force-pushed the bdu/visible-for-testing-annotation branch from 2570bb8 to ef843b6 Compare May 28, 2026 07:00
@bric3 bric3 force-pushed the bdu/visible-for-testing-annotation branch from ef843b6 to da3237c Compare May 28, 2026 07:03
Comment thread internal-api/build.gradle.kts Outdated
Comment thread settings.gradle.kts Outdated
@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented May 28, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 28, 2026

View all feedbacks in Devflow UI.

2026-05-28 07:05:16 UTC ℹ️ Start processing command /merge


2026-05-28 07:05:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-05-28 08:01:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-28 09:14:44 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit ff6fca7 into master May 28, 2026
576 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/visible-for-testing-annotation branch May 28, 2026 09:14
@github-actions github-actions Bot added this to the 1.63.0 milestone May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants