Add VisibleForTesting annotation#11473
Conversation
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, left 2 minor nit comments.
Also worth to announce this annotation to the team in order they start using it.
Also, probably, make sense to update techdebt skill to make Claude to check for this annotation usages.
Debugger benchmarksParameters
See matching parameters
SummaryFound 8 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (350.309 µs) : 303, 398
. : milestone, 350,
basic (312.366 µs) : 305, 319
. : milestone, 312,
loop (9.206 ms) : 9107, 9305
. : milestone, 9206,
section candidate
noprobe (331.758 µs) : 309, 354
. : milestone, 332,
basic (298.407 µs) : 291, 305
. : milestone, 298,
loop (8.986 ms) : 8981, 8991
. : milestone, 8986,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master resultsStartup Time
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
2570bb8 to
ef843b6
Compare
ef843b6 to
da3237c
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What Does This Do
Adds a shared
@VisibleForTestingannotation incomponents:annotations, exposes it throughinternal-api, and replaces testing-visibility comments on loosened members.Motivation
Make testing-only visibility explicit and reusable across modules.
Additional Notes
Validated with
spotlessApplyand focused compile tasks.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge.Jira ticket: [PROJ-IDENT]