Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062877
Total [baseline] (10.914 s) : 0, 10914058
Agent [candidate] (1.065 s) : 0, 1065010
Total [candidate] (10.881 s) : 0, 10881495
section appsec
Agent [baseline] (1.237 s) : 0, 1237037
Total [baseline] (11.034 s) : 0, 11034266
Agent [candidate] (1.238 s) : 0, 1237680
Total [candidate] (11.043 s) : 0, 11042810
section iast
Agent [baseline] (1.234 s) : 0, 1234265
Total [baseline] (11.256 s) : 0, 11256029
Agent [candidate] (1.235 s) : 0, 1234949
Total [candidate] (11.154 s) : 0, 11153666
section profiling
Agent [baseline] (1.192 s) : 0, 1192298
Total [baseline] (10.921 s) : 0, 10921281
Agent [candidate] (1.196 s) : 0, 1196011
Total [candidate] (10.99 s) : 0, 10990041
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (627.685 ms) : 0, 627685
BytebuddyAgent [candidate] (627.719 ms) : 0, 627719
AgentMeter [baseline] (28.986 ms) : 0, 28986
AgentMeter [candidate] (29.058 ms) : 0, 29058
GlobalTracer [baseline] (256.983 ms) : 0, 256983
GlobalTracer [candidate] (257.63 ms) : 0, 257630
AppSec [baseline] (32.759 ms) : 0, 32759
AppSec [candidate] (33.062 ms) : 0, 33062
Debugger [baseline] (63.404 ms) : 0, 63404
Debugger [candidate] (65.223 ms) : 0, 65223
Remote Config [baseline] (629.995 µs) : 0, 630
Remote Config [candidate] (625.312 µs) : 0, 625
Telemetry [baseline] (9.808 ms) : 0, 9808
Telemetry [candidate] (9.937 ms) : 0, 9937
Flare Poller [baseline] (5.378 ms) : 0, 5378
Flare Poller [candidate] (4.591 ms) : 0, 4591
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (656.941 ms) : 0, 656941
BytebuddyAgent [candidate] (657.527 ms) : 0, 657527
AgentMeter [baseline] (11.88 ms) : 0, 11880
AgentMeter [candidate] (11.932 ms) : 0, 11932
GlobalTracer [baseline] (257.728 ms) : 0, 257728
GlobalTracer [candidate] (257.553 ms) : 0, 257553
AppSec [baseline] (167.793 ms) : 0, 167793
AppSec [candidate] (167.55 ms) : 0, 167550
Debugger [baseline] (66.449 ms) : 0, 66449
Debugger [candidate] (66.914 ms) : 0, 66914
Remote Config [baseline] (647.154 µs) : 0, 647
Remote Config [candidate] (669.929 µs) : 0, 670
Telemetry [baseline] (9.363 ms) : 0, 9363
Telemetry [candidate] (9.46 ms) : 0, 9460
Flare Poller [baseline] (3.68 ms) : 0, 3680
Flare Poller [candidate] (3.778 ms) : 0, 3778
IAST [baseline] (25.375 ms) : 0, 25375
IAST [candidate] (25.207 ms) : 0, 25207
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (797.589 ms) : 0, 797589
BytebuddyAgent [candidate] (797.826 ms) : 0, 797826
AgentMeter [baseline] (11.306 ms) : 0, 11306
AgentMeter [candidate] (11.316 ms) : 0, 11316
GlobalTracer [baseline] (248.072 ms) : 0, 248072
GlobalTracer [candidate] (248.356 ms) : 0, 248356
AppSec [baseline] (33.695 ms) : 0, 33695
AppSec [candidate] (30.576 ms) : 0, 30576
Debugger [baseline] (66.956 ms) : 0, 66956
Debugger [candidate] (69.956 ms) : 0, 69956
Remote Config [baseline] (544.705 µs) : 0, 545
Remote Config [candidate] (537.45 µs) : 0, 537
Telemetry [baseline] (8.662 ms) : 0, 8662
Telemetry [candidate] (8.692 ms) : 0, 8692
Flare Poller [baseline] (3.444 ms) : 0, 3444
Flare Poller [candidate] (3.413 ms) : 0, 3413
IAST [baseline] (26.942 ms) : 0, 26942
IAST [candidate] (27.125 ms) : 0, 27125
section profiling
ProfilingAgent [baseline] (99.258 ms) : 0, 99258
ProfilingAgent [candidate] (99.277 ms) : 0, 99277
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (683.146 ms) : 0, 683146
BytebuddyAgent [candidate] (685.497 ms) : 0, 685497
AgentMeter [baseline] (8.573 ms) : 0, 8573
AgentMeter [candidate] (8.541 ms) : 0, 8541
GlobalTracer [baseline] (216.282 ms) : 0, 216282
GlobalTracer [candidate] (217.178 ms) : 0, 217178
AppSec [baseline] (32.585 ms) : 0, 32585
AppSec [candidate] (33.056 ms) : 0, 33056
Debugger [baseline] (67.058 ms) : 0, 67058
Debugger [candidate] (67.294 ms) : 0, 67294
Remote Config [baseline] (624.289 µs) : 0, 624
Remote Config [candidate] (623.068 µs) : 0, 623
Telemetry [baseline] (9.133 ms) : 0, 9133
Telemetry [candidate] (8.927 ms) : 0, 8927
Flare Poller [baseline] (3.716 ms) : 0, 3716
Flare Poller [candidate] (3.763 ms) : 0, 3763
Profiling [baseline] (99.839 ms) : 0, 99839
Profiling [candidate] (99.852 ms) : 0, 99852
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074142
Total [baseline] (8.758 s) : 0, 8757792
Agent [candidate] (1.065 s) : 0, 1065079
Total [candidate] (8.73 s) : 0, 8730476
section iast
Agent [baseline] (1.238 s) : 0, 1237812
Total [baseline] (9.404 s) : 0, 9403778
Agent [candidate] (1.233 s) : 0, 1233385
Total [candidate] (9.387 s) : 0, 9386572
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (635.036 ms) : 0, 635036
BytebuddyAgent [candidate] (627.344 ms) : 0, 627344
AgentMeter [baseline] (29.359 ms) : 0, 29359
AgentMeter [candidate] (29.011 ms) : 0, 29011
GlobalTracer [baseline] (258.812 ms) : 0, 258812
GlobalTracer [candidate] (257.86 ms) : 0, 257860
AppSec [baseline] (33.331 ms) : 0, 33331
AppSec [candidate] (32.877 ms) : 0, 32877
Debugger [baseline] (64.09 ms) : 0, 64090
Debugger [candidate] (63.672 ms) : 0, 63672
Remote Config [baseline] (636.157 µs) : 0, 636
Remote Config [candidate] (616.531 µs) : 0, 617
Telemetry [baseline] (10.017 ms) : 0, 10017
Telemetry [candidate] (10.455 ms) : 0, 10455
Flare Poller [baseline] (5.286 ms) : 0, 5286
Flare Poller [candidate] (6.019 ms) : 0, 6019
section iast
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (800.837 ms) : 0, 800837
BytebuddyAgent [candidate] (798.407 ms) : 0, 798407
AgentMeter [baseline] (11.519 ms) : 0, 11519
AgentMeter [candidate] (11.273 ms) : 0, 11273
GlobalTracer [baseline] (248.941 ms) : 0, 248941
GlobalTracer [candidate] (248.05 ms) : 0, 248050
AppSec [baseline] (31.322 ms) : 0, 31322
AppSec [candidate] (33.651 ms) : 0, 33651
Debugger [baseline] (68.177 ms) : 0, 68177
Debugger [candidate] (64.999 ms) : 0, 64999
Remote Config [baseline] (538.035 µs) : 0, 538
Remote Config [candidate] (536.907 µs) : 0, 537
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (8.685 ms) : 0, 8685
Flare Poller [baseline] (3.438 ms) : 0, 3438
Flare Poller [candidate] (3.475 ms) : 0, 3475
IAST [baseline] (27.196 ms) : 0, 27196
IAST [candidate] (27.094 ms) : 0, 27094
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (1.175 ms) : 1164, 1186
. : milestone, 1175,
iast (3.222 ms) : 3179, 3265
. : milestone, 3222,
iast_FULL (5.784 ms) : 5726, 5842
. : milestone, 5784,
iast_GLOBAL (3.562 ms) : 3500, 3623
. : milestone, 3562,
profiling (2.108 ms) : 2090, 2127
. : milestone, 2108,
tracing (1.788 ms) : 1774, 1803
. : milestone, 1788,
section candidate
no_agent (1.182 ms) : 1171, 1194
. : milestone, 1182,
iast (3.149 ms) : 3115, 3183
. : milestone, 3149,
iast_FULL (5.736 ms) : 5679, 5792
. : milestone, 5736,
iast_GLOBAL (3.626 ms) : 3565, 3687
. : milestone, 3626,
profiling (1.95 ms) : 1934, 1967
. : milestone, 1950,
tracing (1.804 ms) : 1789, 1819
. : milestone, 1804,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (17.372 ms) : 17196, 17548
. : milestone, 17372,
appsec (18.367 ms) : 18181, 18553
. : milestone, 18367,
code_origins (17.548 ms) : 17374, 17721
. : milestone, 17548,
iast (17.596 ms) : 17421, 17770
. : milestone, 17596,
profiling (18.502 ms) : 18317, 18688
. : milestone, 18502,
tracing (17.631 ms) : 17456, 17806
. : milestone, 17631,
section candidate
no_agent (19.027 ms) : 18831, 19224
. : milestone, 19027,
appsec (18.45 ms) : 18262, 18637
. : milestone, 18450,
code_origins (17.692 ms) : 17516, 17868
. : milestone, 17692,
iast (18.029 ms) : 17847, 18210
. : milestone, 18029,
profiling (19.538 ms) : 19342, 19734
. : milestone, 19538,
tracing (17.544 ms) : 17369, 17718
. : milestone, 17544,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
appsec (14.683 s) : 14683000, 14683000
. : milestone, 14683000,
iast (17.713 s) : 17713000, 17713000
. : milestone, 17713000,
iast_GLOBAL (18.086 s) : 18086000, 18086000
. : milestone, 18086000,
profiling (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
tracing (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
section candidate
no_agent (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
appsec (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
iast (18.508 s) : 18508000, 18508000
. : milestone, 18508000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
. : milestone, 17979000,
profiling (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
tracing (14.613 s) : 14613000, 14613000
. : milestone, 14613000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~8bfae7a4b5, baseline=1.60.0-SNAPSHOT~5418feb23a
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.729 ms) : 3510, 3948
. : milestone, 3729,
iast (2.268 ms) : 2198, 2337
. : milestone, 2268,
iast_GLOBAL (2.298 ms) : 2228, 2367
. : milestone, 2298,
profiling (2.108 ms) : 2051, 2165
. : milestone, 2108,
tracing (2.079 ms) : 2025, 2133
. : milestone, 2079,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.74 ms) : 3523, 3956
. : milestone, 3740,
iast (2.263 ms) : 2193, 2333
. : milestone, 2263,
iast_GLOBAL (2.307 ms) : 2237, 2377
. : milestone, 2307,
profiling (2.104 ms) : 2047, 2160
. : milestone, 2104,
tracing (2.081 ms) : 2027, 2135
. : milestone, 2081,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
7a4d869 to
32dba74
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
f4aa3fe to
a7f8b76
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
is the client stats part being done in a different PR? https://github.com/DataDog/datadog-agent/pull/45982/changes |
yep I will stack another PR on top |
|
could you send a few test data on datadog with this PR to double check from UI |
...-java-sdk-1.11/src/main/java/datadog/trace/instrumentation/aws/v0/AwsSdkClientDecorator.java
Show resolved
Hide resolved
d070b9a to
8bfae7a
Compare
What Does This Do
This change introduces service name source tracking, allowing us to record which integration or feature overrides the service name on a span.
To support this, a new
setServiceNameAPI has been added toAgentSpan. In addition to the service name, this method also accepts aCharSequencerepresenting the source of the override.For durability, the old signature has been deprecated on AgentSpan. Also, a forbiddenApi check has been added to all the integration to discourage the usage of the previous method that is missing the source of override.
When a source is set on a span, it is automatically propagated to its local children, since they inherit the same service name.
Manual tracing is currently out of scope. However, in the future we may extend this mechanism to track manual overrides as a
"manual"source.If a source is present on a span, an eager post-processor records it under the
_dd.svc_srctag.Please note that trace statistics will also need to incorporate this source information. That update will be handled in a separate PR.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.