Skip to content

Do not break the JMS instrumentation when unable to access a property #10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarziali merged 2 commits into from
Dec 29, 2025
Merged

Do not break the JMS instrumentation when unable to access a property #10255

amarziali merged 2 commits into from
Dec 29, 2025

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Dec 19, 2025

What Does This Do

Solves:


  java.lang.RuntimeException
  at datadog.trace.instrumentation.jms.MessageExtractAdapter.forEachKey(MessageExtractAdapter.java:48)
  at datadog.trace.instrumentation.jms.MessageExtractAdapter.forEachKey(MessageExtractAdapter.java:18)
  at datadog.trace.agent.core.propagation.HttpCodec$ExtractionCache.<init>(HttpCodec.java:320)

This is caught by the bytebuddy error handler meaning that breaks the jms instrumentation. This PR handle the case more softly

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner December 19, 2025 11:45
@amarziali amarziali added type: bug Bug report and fix inst: jms JMS instrumentation tag: telemetry error reported Reported by error telemetry labels Dec 19, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jms-npe
git_commit_date 1766146679 1766148063
git_commit_sha bcbd429 a956837
release_version 1.58.0-SNAPSHOT~bcbd429b85 1.58.0-SNAPSHOT~a956837713
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1766149974 1766149974
ci_job_id 1309350023 1309350023
ci_pipeline_id 87766838 87766838
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7nuhtks8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7nuhtks8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085163
Total [baseline] (10.855 s) : 0, 10854832
Agent [candidate] (1.097 s) : 0, 1096861
Total [candidate] (10.837 s) : 0, 10836538
section appsec
Agent [baseline] (1.275 s) : 0, 1274617
Total [baseline] (10.97 s) : 0, 10969693
Agent [candidate] (1.267 s) : 0, 1266858
Total [candidate] (11.161 s) : 0, 11160751
section iast
Agent [baseline] (1.241 s) : 0, 1240685
Total [baseline] (11.227 s) : 0, 11227242
Agent [candidate] (1.235 s) : 0, 1235201
Total [candidate] (11.251 s) : 0, 11250674
section profiling
Agent [baseline] (1.222 s) : 0, 1222215
Total [baseline] (11.026 s) : 0, 11025741
Agent [candidate] (1.215 s) : 0, 1215289
Total [candidate] (11.168 s) : 0, 11168102
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent appsec 1.275 s 189.454 ms (17.5%)
Agent iast 1.241 s 155.522 ms (14.3%)
Agent profiling 1.222 s 137.052 ms (12.6%)
Total tracing 10.855 s -
Total appsec 10.97 s 114.86 ms (1.1%)
Total iast 11.227 s 372.409 ms (3.4%)
Total profiling 11.026 s 170.908 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent appsec 1.267 s 169.997 ms (15.5%)
Agent iast 1.235 s 138.34 ms (12.6%)
Agent profiling 1.215 s 118.428 ms (10.8%)
Total tracing 10.837 s -
Total appsec 11.161 s 324.213 ms (3.0%)
Total iast 11.251 s 414.137 ms (3.8%)
Total profiling 11.168 s 331.564 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (651.157 ms) : 0, 651157
BytebuddyAgent [candidate] (655.77 ms) : 0, 655770
GlobalTracer [baseline] (283.328 ms) : 0, 283328
GlobalTracer [candidate] (288.207 ms) : 0, 288207
AppSec [baseline] (32.211 ms) : 0, 32211
AppSec [candidate] (32.907 ms) : 0, 32907
Debugger [baseline] (67.506 ms) : 0, 67506
Debugger [candidate] (69.431 ms) : 0, 69431
Remote Config [baseline] (638.393 µs) : 0, 638
Remote Config [candidate] (650.252 µs) : 0, 650
Telemetry [baseline] (9.194 ms) : 0, 9194
Telemetry [candidate] (9.216 ms) : 0, 9216
Flare Poller [baseline] (4.512 ms) : 0, 4512
Flare Poller [candidate] (3.843 ms) : 0, 3843
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (696.689 ms) : 0, 696689
BytebuddyAgent [candidate] (691.991 ms) : 0, 691991
GlobalTracer [baseline] (260.532 ms) : 0, 260532
GlobalTracer [candidate] (259.359 ms) : 0, 259359
IAST [baseline] (24.89 ms) : 0, 24890
IAST [candidate] (24.672 ms) : 0, 24672
AppSec [baseline] (173.544 ms) : 0, 173544
AppSec [candidate] (172.538 ms) : 0, 172538
Debugger [baseline] (68.55 ms) : 0, 68550
Debugger [candidate] (68.176 ms) : 0, 68176
Remote Config [baseline] (709.236 µs) : 0, 709
Remote Config [candidate] (712.309 µs) : 0, 712
Telemetry [baseline] (8.971 ms) : 0, 8971
Telemetry [candidate] (8.904 ms) : 0, 8904
Flare Poller [baseline] (3.796 ms) : 0, 3796
Flare Poller [candidate] (3.766 ms) : 0, 3766
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (802.908 ms) : 0, 802908
BytebuddyAgent [candidate] (798.536 ms) : 0, 798536
GlobalTracer [baseline] (259.227 ms) : 0, 259227
GlobalTracer [candidate] (258.631 ms) : 0, 258631
IAST [baseline] (27.652 ms) : 0, 27652
IAST [candidate] (27.454 ms) : 0, 27454
AppSec [baseline] (33.194 ms) : 0, 33194
AppSec [candidate] (33.032 ms) : 0, 33032
Debugger [baseline] (68.165 ms) : 0, 68165
Debugger [candidate] (68.186 ms) : 0, 68186
Remote Config [baseline] (613.656 µs) : 0, 614
Remote Config [candidate] (590.113 µs) : 0, 590
Telemetry [baseline] (8.524 ms) : 0, 8524
Telemetry [candidate] (8.587 ms) : 0, 8587
Flare Poller [baseline] (3.517 ms) : 0, 3517
Flare Poller [candidate] (3.55 ms) : 0, 3550
section profiling
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (713.619 ms) : 0, 713619
BytebuddyAgent [candidate] (707.297 ms) : 0, 707297
GlobalTracer [baseline] (223.673 ms) : 0, 223673
GlobalTracer [candidate] (222.858 ms) : 0, 222858
AppSec [baseline] (32.766 ms) : 0, 32766
AppSec [candidate] (32.499 ms) : 0, 32499
Debugger [baseline] (68.814 ms) : 0, 68814
Debugger [candidate] (68.93 ms) : 0, 68930
Remote Config [baseline] (656.494 µs) : 0, 656
Remote Config [candidate] (629.871 µs) : 0, 630
Telemetry [baseline] (8.894 ms) : 0, 8894
Telemetry [candidate] (8.949 ms) : 0, 8949
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.825 ms) : 0, 3825
ProfilingAgent [baseline] (98.058 ms) : 0, 98058
ProfilingAgent [candidate] (99.212 ms) : 0, 99212
Profiling [baseline] (98.639 ms) : 0, 98639
Profiling [candidate] (99.798 ms) : 0, 99798
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089695
Total [baseline] (8.768 s) : 0, 8767718
Agent [candidate] (1.09 s) : 0, 1090310
Total [candidate] (8.761 s) : 0, 8760746
section iast
Agent [baseline] (1.225 s) : 0, 1225052
Total [baseline] (9.382 s) : 0, 9382454
Agent [candidate] (1.224 s) : 0, 1224470
Total [candidate] (9.349 s) : 0, 9349452
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.225 s 135.357 ms (12.4%)
Total tracing 8.768 s -
Total iast 9.382 s 614.736 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.224 s 134.16 ms (12.3%)
Total tracing 8.761 s -
Total iast 9.349 s 588.706 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (655.058 ms) : 0, 655058
BytebuddyAgent [candidate] (655.294 ms) : 0, 655294
GlobalTracer [baseline] (284.028 ms) : 0, 284028
GlobalTracer [candidate] (284.968 ms) : 0, 284968
AppSec [baseline] (32.512 ms) : 0, 32512
AppSec [candidate] (32.507 ms) : 0, 32507
Debugger [baseline] (66.998 ms) : 0, 66998
Debugger [candidate] (66.601 ms) : 0, 66601
Remote Config [baseline] (612.447 µs) : 0, 612
Remote Config [candidate] (628.21 µs) : 0, 628
Telemetry [baseline] (9.107 ms) : 0, 9107
Telemetry [candidate] (9.739 ms) : 0, 9739
Flare Poller [baseline] (4.521 ms) : 0, 4521
Flare Poller [candidate] (3.683 ms) : 0, 3683
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (792.753 ms) : 0, 792753
BytebuddyAgent [candidate] (792.081 ms) : 0, 792081
GlobalTracer [baseline] (256.108 ms) : 0, 256108
GlobalTracer [candidate] (256.316 ms) : 0, 256316
IAST [baseline] (27.02 ms) : 0, 27020
IAST [candidate] (26.984 ms) : 0, 26984
AppSec [baseline] (33.948 ms) : 0, 33948
AppSec [candidate] (35.352 ms) : 0, 35352
Debugger [baseline] (65.946 ms) : 0, 65946
Debugger [candidate] (64.424 ms) : 0, 64424
Remote Config [baseline] (605.747 µs) : 0, 606
Remote Config [candidate] (609.261 µs) : 0, 609
Telemetry [baseline] (8.518 ms) : 0, 8518
Telemetry [candidate] (8.475 ms) : 0, 8475
Flare Poller [baseline] (3.552 ms) : 0, 3552
Flare Poller [candidate] (3.522 ms) : 0, 3522
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jms-npe
git_commit_date 1766146679 1766148063
git_commit_sha bcbd429 a956837
release_version 1.58.0-SNAPSHOT~bcbd429b85 1.58.0-SNAPSHOT~a956837713
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1766150625 1766150625
ci_job_id 1309350026 1309350026
ci_pipeline_id 87766838 87766838
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7ec7y3l5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7ec7y3l5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-171.880µs; -63.698µs] or [-5.970%; -2.212%]		 unstable
[-11.963ms; +3.577ms] or [-98.673%; +29.503%]		 unstable
[-87.753op/s; +185.816op/s] or [-7.005%; +14.832%]		 2.761ms 7.931ms 1301.812op/s 2.879ms 12.124ms 1252.781op/s
scenario:load:insecure-bank:profiling:high_load worse
[+136.661µs; +286.775µs] or [+8.351%; +17.525%]		 unstable
[+0.889ms; +1.743ms] or [+19.713%; +38.656%]		 unstable
[-645.399op/s; -162.726op/s] or [-28.287%; -7.132%]		 1.848ms 5.825ms 1877.531op/s 1.636ms 4.509ms 2281.594op/s
scenario:load:insecure-bank:iast:high_load worse
[+93.189µs; +168.540µs] or [+3.865%; +6.990%]		 unsure
[+99.608µs; +515.699µs] or [+1.407%; +7.284%]		 unstable
[-211.893op/s; +86.455op/s] or [-14.402%; +5.876%]		 2.542ms 7.387ms 1408.594op/s 2.411ms 7.080ms 1471.312op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.194 ms) : 1182, 1206
.   : milestone, 1194,
iast (3.107 ms) : 3071, 3143
.   : milestone, 3107,
iast_FULL (5.841 ms) : 5782, 5899
.   : milestone, 5841,
iast_GLOBAL (3.669 ms) : 3609, 3729
.   : milestone, 3669,
profiling (1.977 ms) : 1960, 1994
.   : milestone, 1977,
tracing (1.766 ms) : 1752, 1780
.   : milestone, 1766,
section candidate
no_agent (1.174 ms) : 1162, 1185
.   : milestone, 1174,
iast (3.249 ms) : 3207, 3291
.   : milestone, 3249,
iast_FULL (5.905 ms) : 5845, 5965
.   : milestone, 5905,
iast_GLOBAL (3.52 ms) : 3470, 3570
.   : milestone, 3520,
profiling (2.419 ms) : 2394, 2443
.   : milestone, 2419,
tracing (1.784 ms) : 1769, 1799
.   : milestone, 1784,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.194 ms [1.182 ms, 1.206 ms] -
iast 3.107 ms [3.071 ms, 3.143 ms] 1.913 ms (160.2%)
iast_FULL 5.841 ms [5.782 ms, 5.899 ms] 4.647 ms (389.1%)
iast_GLOBAL 3.669 ms [3.609 ms, 3.729 ms] 2.475 ms (207.2%)
profiling 1.977 ms [1.96 ms, 1.994 ms] 782.717 µs (65.5%)
tracing 1.766 ms [1.752 ms, 1.78 ms] 571.524 µs (47.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.174 ms [1.162 ms, 1.185 ms] -
iast 3.249 ms [3.207 ms, 3.291 ms] 2.075 ms (176.7%)
iast_FULL 5.905 ms [5.845 ms, 5.965 ms] 4.731 ms (403.0%)
iast_GLOBAL 3.52 ms [3.47 ms, 3.57 ms] 2.346 ms (199.9%)
profiling 2.419 ms [2.394 ms, 2.443 ms] 1.245 ms (106.0%)
tracing 1.784 ms [1.769 ms, 1.799 ms] 610.111 µs (52.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.616 ms) : 18426, 18805
.   : milestone, 18616,
appsec (19.069 ms) : 18876, 19262
.   : milestone, 19069,
code_origins (17.666 ms) : 17490, 17843
.   : milestone, 17666,
iast (17.834 ms) : 17655, 18012
.   : milestone, 17834,
profiling (18.761 ms) : 18570, 18952
.   : milestone, 18761,
tracing (17.72 ms) : 17542, 17898
.   : milestone, 17720,
section candidate
no_agent (19.293 ms) : 19097, 19489
.   : milestone, 19293,
appsec (19.631 ms) : 19433, 19830
.   : milestone, 19631,
code_origins (18.046 ms) : 17870, 18222
.   : milestone, 18046,
iast (17.921 ms) : 17741, 18100
.   : milestone, 17921,
profiling (18.93 ms) : 18737, 19123
.   : milestone, 18930,
tracing (17.91 ms) : 17732, 18089
.   : milestone, 17910,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.616 ms [18.426 ms, 18.805 ms] -
appsec 19.069 ms [18.876 ms, 19.262 ms] 453.413 µs (2.4%)
code_origins 17.666 ms [17.49 ms, 17.843 ms] -949.115 µs (-5.1%)
iast 17.834 ms [17.655 ms, 18.012 ms] -781.964 µs (-4.2%)
profiling 18.761 ms [18.57 ms, 18.952 ms] 145.411 µs (0.8%)
tracing 17.72 ms [17.542 ms, 17.898 ms] -895.914 µs (-4.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.293 ms [19.097 ms, 19.489 ms] -
appsec 19.631 ms [19.433 ms, 19.83 ms] 337.942 µs (1.8%)
code_origins 18.046 ms [17.87 ms, 18.222 ms] -1.247 ms (-6.5%)
iast 17.921 ms [17.741 ms, 18.1 ms] -1.372 ms (-7.1%)
profiling 18.93 ms [18.737 ms, 19.123 ms] -363.21 µs (-1.9%)
tracing 17.91 ms [17.732 ms, 18.089 ms] -1.383 ms (-7.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jms-npe
git_commit_date 1766146679 1766148063
git_commit_sha bcbd429 a956837
release_version 1.58.0-SNAPSHOT~bcbd429b85 1.58.0-SNAPSHOT~a956837713
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1766150347 1766150347
ci_job_id 1309350028 1309350028
ci_pipeline_id 87766838 87766838
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-bews1jgg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-bews1jgg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.897 s) : 14897000, 14897000
.   : milestone, 14897000,
appsec (14.232 s) : 14232000, 14232000
.   : milestone, 14232000,
iast (18.367 s) : 18367000, 18367000
.   : milestone, 18367000,
iast_GLOBAL (17.723 s) : 17723000, 17723000
.   : milestone, 17723000,
profiling (15.403 s) : 15403000, 15403000
.   : milestone, 15403000,
tracing (14.786 s) : 14786000, 14786000
.   : milestone, 14786000,
section candidate
no_agent (14.929 s) : 14929000, 14929000
.   : milestone, 14929000,
appsec (14.589 s) : 14589000, 14589000
.   : milestone, 14589000,
iast (18.161 s) : 18161000, 18161000
.   : milestone, 18161000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
.   : milestone, 18003000,
profiling (14.931 s) : 14931000, 14931000
.   : milestone, 14931000,
tracing (14.65 s) : 14650000, 14650000
.   : milestone, 14650000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.897 s [14.897 s, 14.897 s] -
appsec 14.232 s [14.232 s, 14.232 s] -665.0 ms (-4.5%)
iast 18.367 s [18.367 s, 18.367 s] 3.47 s (23.3%)
iast_GLOBAL 17.723 s [17.723 s, 17.723 s] 2.826 s (19.0%)
profiling 15.403 s [15.403 s, 15.403 s] 506.0 ms (3.4%)
tracing 14.786 s [14.786 s, 14.786 s] -111.0 ms (-0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.929 s [14.929 s, 14.929 s] -
appsec 14.589 s [14.589 s, 14.589 s] -340.0 ms (-2.3%)
iast 18.161 s [18.161 s, 18.161 s] 3.232 s (21.6%)
iast_GLOBAL 18.003 s [18.003 s, 18.003 s] 3.074 s (20.6%)
profiling 14.931 s [14.931 s, 14.931 s] 2.0 ms (0.0%)
tracing 14.65 s [14.65 s, 14.65 s] -279.0 ms (-1.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.737 ms) : 3517, 3957
.   : milestone, 3737,
iast (2.221 ms) : 2156, 2285
.   : milestone, 2221,
iast_GLOBAL (2.261 ms) : 2196, 2326
.   : milestone, 2261,
profiling (2.478 ms) : 2316, 2640
.   : milestone, 2478,
tracing (2.049 ms) : 1998, 2100
.   : milestone, 2049,
section candidate
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (3.649 ms) : 3434, 3864
.   : milestone, 3649,
iast (2.226 ms) : 2161, 2291
.   : milestone, 2226,
iast_GLOBAL (2.261 ms) : 2196, 2326
.   : milestone, 2261,
profiling (2.086 ms) : 2032, 2140
.   : milestone, 2086,
tracing (2.049 ms) : 1998, 2100
.   : milestone, 2049,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 3.737 ms [3.517 ms, 3.957 ms] 2.258 ms (152.6%)
iast 2.221 ms [2.156 ms, 2.285 ms] 741.562 µs (50.1%)
iast_GLOBAL 2.261 ms [2.196 ms, 2.326 ms] 781.677 µs (52.8%)
profiling 2.478 ms [2.316 ms, 2.64 ms] 998.626 µs (67.5%)
tracing 2.049 ms [1.998 ms, 2.1 ms] 569.807 µs (38.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 3.649 ms [3.434 ms, 3.864 ms] 2.168 ms (146.4%)
iast 2.226 ms [2.161 ms, 2.291 ms] 745.154 µs (50.3%)
iast_GLOBAL 2.261 ms [2.196 ms, 2.326 ms] 780.009 µs (52.7%)
profiling 2.086 ms [2.032 ms, 2.14 ms] 604.6 µs (40.8%)
tracing 2.049 ms [1.998 ms, 2.1 ms] 567.856 µs (38.3%)

mcculls
mcculls approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@amarziali amarziali merged commit e9af3f4 into master Dec 29, 2025
559 checks passed
@amarziali amarziali deleted the andrea.marziali/jms-npe branch December 29, 2025 12:56
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

Assignees

No one assigned

Labels

inst: jms JMS instrumentation tag: telemetry error reported Reported by error telemetry type: bug Bug report and fix

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @mcculls