[RUM-14431] Change Webview package's requiresMainQueueSetup return value to prevent deadlock
#1130
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdn34dd
changed the title
requiresMainQueueSetup to NO to prevent deadlockrequiresMainQueueSetup return value to prevent deadlock
cdn34dd
changed the title
requiresMainQueueSetup return value to prevent deadlockrequiresMainQueueSetup return value to prevent deadlock
cdn34dd
deleted the
carlosnogueira/RUM-14431/fix-webview-ios-new-arch-deadlock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change
requiresMainQueueSetupfromYEStoNOinRCTDatadogWebViewManagerto prevent deadlock with React Native's Fabric animation system.The issue occurs intermittently when lazy-loading the Webview module during navigation events. When the issue occurs the module would be kept waiting for the main thread indefinitely while the main thread was blocked on
ComponentDescriptorRegistry'sshared lock.Review checklist (to be filled by reviewers)