Skip to content

[RUM-14275] Enable Jank Stats Tracking on Android #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbarrio merged 1 commit into from
Feb 6, 2026
+9 −1
Merged

[RUM-14275] Enable Jank Stats Tracking on Android #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion example-new-architecture/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
DdLogs,
DdTrace,
TrackingConsent,
LogsConfiguration,
} from '@datadog/mobile-react-native';
import React from 'react';
import type {PropsWithChildren} from 'react';
Expand Down Expand Up @@ -46,7 +47,9 @@ import {APPLICATION_ID, CLIENT_TOKEN, ENVIRONMENT} from './ddCredentials';
trackErrors: true,
sessionSampleRate: 100,
telemetrySampleRate: 100,
}
},
logsConfiguration: {},
Copy link
Contributor Author

@sbarrio sbarrio Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were missing from the example app.

traceConfiguration: {}
}
);
config.verbosity = SdkVerbosity.DEBUG;
Expand Down
5 changes: 5 additions & 0 deletions packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkImplementation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ class DdSdkImplementation(
val nativeInitialization = DdSdkNativeInitialization(appContext, datadog, ddTelemetry)
nativeInitialization.initialize(ddSdkConfiguration)

val activity = reactContext.currentActivity
if (ddSdkConfiguration.rumConfiguration != null && activity != null) {
Copy link

@aleksandr-gringauz aleksandr-gringauz Feb 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to better understand. Is it possible that Activity is actually null here? Or currentActivity is just nullable in ReactContext and in the real life we will never see null here?

Copy link
Contributor Author

@sbarrio sbarrio Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's possible for the Activity to be null at this point, but as you mentioned, since it is nullable we need to be overly cautious.

Also, the first check is there to avoid enabling this if RUM is not enabled.

datadog.getRumMonitor()._getInternal()?.enableJankStatsTracking(activity)
}

this.frameRateProvider = createFrameRateProvider(ddSdkConfiguration)

reactContext.addLifecycleEventListener(object : LifecycleEventListener {
Expand Down
Loading