[FIX][Benchmarks] RumAuto scenario networking improvements #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sbarrio/chore/rumauto-benchmark-network-improvements
cdn34dd
approved these changes
Feb 6, 2026
Comment on lines
+30
to
+66
| private async processQueue(): Promise<void> { | ||
| if (this.isProcessing) { | ||
| return; | ||
| } | ||
|
|
||
| this.isProcessing = true; | ||
|
|
||
| while (this.requestQueue.length > 0 && this.activeRequests < MAX_CONCURRENT_REQUESTS) { | ||
| const request = this.requestQueue.shift(); | ||
| if (!request) break; | ||
|
|
||
| this.activeRequests++; | ||
|
|
||
| try { | ||
| await this.delay(REQUEST_DELAY_MS); | ||
|
|
||
| const response = await fetch(request.url); | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error(`HTTP ${response.status}: ${response.statusText}`); | ||
| } | ||
|
|
||
| const data = await response.json(); | ||
| request.resolve(data); | ||
| } catch (error) { | ||
| request.reject(error); | ||
| } finally { | ||
| this.activeRequests--; | ||
| } | ||
| } | ||
|
|
||
| this.isProcessing = false; | ||
|
|
||
| if (this.requestQueue.length > 0) { | ||
| this.processQueue(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I don't care too much since this is for the benchmarks app, however I believe this function should be refactored a bit, there is no concurrency happening here, mostly due to the await inside the while loop, which makes the request processing sequentially, and the isProcessing prevents any requests from re-entering the the processQueue.
So this is simply defering the execution of requests not paralelizing them.
Contributor
Author
There was a problem hiding this comment.
Yeah, that's the whole point of it, to act as a gatekeeper to not overwhelm the API and get cut out. Paralellization was not the aim for this. I do agree however that it could be refactored a bit.
sbarrio
deleted the
sbarrio/chore/rumauto-benchmark-network-improvements
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces 2 improvements to the rumAuto scenario on the benchmark app, both aimed to improve the reliability and stability of synthetics run executing this scenario:
429'd by the test API.Motivation
The RUM Auto scenario test runs are very flimsy and unreliable due to the request rate limits imposed by the test API.
Review checklist (to be filled by reviewers)