-
Notifications
You must be signed in to change notification settings - Fork 54
FFL-900 Addresing feature/flags PR feedback
#1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/flags
Are you sure you want to change the base?
FFL-900 Addresing feature/flags PR feedback
#1113
Conversation
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions after re-reading.
| ## Setup | ||
|
|
||
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before using it, install and set up the core [`mobile-react-native`][3] SDK. | ||
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before starting using Datadog Feature Flags, install and set up the core [`@datadog/mobile-react-native`][3] SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before starting using Datadog Feature Flags, install and set up the core [`@datadog/mobile-react-native`][3] SDK. | |
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Install and set up the core [`@datadog/mobile-react-native`][3] SDK to start using Datadog Feature Flags. |
| </DatadogProvider> | ||
| ``` | ||
|
|
||
| After completing this setup, your app should be ready for flag evaluation with OpenFeature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| After completing this setup, your app should be ready for flag evaluation with OpenFeature. | |
| After completing this setup, your app is ready for flag evaluation with OpenFeature. |
…es-to-3.0.0 [FIX] Bump "@datadog/mobile-react-native" to ^3.0.0 on peerDependencies
[RELEASE] React Native SDK v3.0.1
…y-text-extraction-for-rn-84 [CHORE][iOS] Fix Session Replay Text Extraction on RN 0.84
…re-flags-pr-feedback
…sbarrio/chore/rumauto-benchmark-network-improvements
…e-missing-on-android [RUM-14275] Enable Jank Stats Tracking on Android
[FIX] Restore utf8ByteLength to replace use of Buffer.byteLength()
…-network-improvements [FIX][Benchmarks] RumAuto scenario networking improvements
[RUM-13802][CHORE] Add workflow for Github issue notifications to Slack
…-break-when-updating-native-versions-md [CHORE] Remove extra line break when adding a new version entry
…sh-reports [RUM-6208][Fix] Enable NDK Crash Reports
…re-flags-pr-feedback
[RELEASE] React Native SDK v3.0.2
…re-flags-pr-feedback
What does this PR do?
Motivation
(I have no push rights in the
feature/flagsbranch)Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)