Skip to content

[FFL-1720] Evaluation Logging: Storage & Network Infrastructure#3146

Merged
typotter merged 18 commits intofeature/flags-evaluations-loggingfrom
typo/FFL-1720-pr3-storage-network
Feb 17, 2026
Merged

[FFL-1720] Evaluation Logging: Storage & Network Infrastructure#3146
typotter merged 18 commits intofeature/flags-evaluations-loggingfrom
typo/FFL-1720-pr3-storage-network

Conversation

@typotter
Copy link
Copy Markdown
Contributor

@typotter typotter commented Jan 22, 2026

🥞 Evaluation Logging Stacked Pull Requests 🥞

🔲 Integration & Configuration (PR #3147)
👉 Storage & Network Infrastructure (this PR)
☑️ Aggregation Engine & Test Utilities (PR #3145)
☑️FlagEvaluation Schema (PR #3166)
☑️ Event Schema & Data Models (PR #3144)
☑️ Evaluations Subfeature (PR #3159)
feature/flags-evaluations-logging (feature branch)

Datadog Internal
🎟️ Ticket: FFL-1720 - Implement Evaluation Logging for Android SDK

What does this PR do?

Implements the infrastructure for persisting evaluation events to disk and uploading them to Datadog's intake endpoint. Connects the aggregation engine (PR #3145) to the SDK Core's storage and network layer.

Motivation

We need to implement Evaluation Logging to provide comprehensive visibility into all feature flag evaluations, including defaults, errors, and successful matches. This goes beyond exposure logging by capturing aggregated metrics about evaluation frequency, error rates, and runtime default usage across all flags.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Copy link
Copy Markdown
Contributor Author

typotter commented Jan 22, 2026

@typotter typotter force-pushed the typo/FFL-1720-pr2-aggregation branch from 95f4c0a to a0e7df9 Compare January 22, 2026 16:29
@typotter typotter force-pushed the typo/FFL-1720-pr3-storage-network branch 2 times, most recently from 7ceef6b to 7c8d6b7 Compare January 22, 2026 21:27
@datadog-official

This comment has been minimized.

@typotter typotter mentioned this pull request Jan 27, 2026
3 tasks
@typotter typotter force-pushed the typo/FFL-1720-pr2-aggregation branch 2 times, most recently from 968dc68 to 80c8de7 Compare January 28, 2026 06:55
@typotter typotter force-pushed the typo/FFL-1720-pr3-storage-network branch from 7c8d6b7 to a195a29 Compare January 28, 2026 06:56
@typotter typotter force-pushed the typo/FFL-1720-pr2-aggregation branch from 2eb16ca to 0cfb30a Compare January 28, 2026 07:27
@typotter typotter force-pushed the typo/FFL-1720-pr3-storage-network branch from a195a29 to 4f4c253 Compare January 28, 2026 07:35
@typotter typotter force-pushed the typo/FFL-1720-pr2-aggregation branch from 0cfb30a to 141cded Compare January 28, 2026 07:50
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 53.09735% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.87%. Comparing base (adb81d5) to head (0b4df16).

Files with missing lines Patch % Lines
...tadog/android/flags/internal/EvaluationsFeature.kt 2.44% 40 Missing ⚠️
...tadog/android/flags/internal/DatadogFlagsClient.kt 67.86% 6 Missing and 3 partials ⚠️
...in/kotlin/com/datadog/android/flags/FlagsClient.kt 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           feature/flags-evaluations-logging    #3146      +/-   ##
=====================================================================
- Coverage                              71.00%   70.87%   -0.13%     
=====================================================================
  Files                                    905      906       +1     
  Lines                                  33310    33418     +108     
  Branches                                5614     5635      +21     
=====================================================================
+ Hits                                   23650    23684      +34     
- Misses                                  8102     8159      +57     
- Partials                                1558     1575      +17     
Files with missing lines Coverage Δ
...com/datadog/android/flags/internal/FlagsFeature.kt 85.07% <100.00%> (+0.46%) ⬆️
...id/flags/internal/net/EvaluationsRequestFactory.kt 100.00% <100.00%> (+25.00%) ⬆️
...gs/internal/storage/EvaluationEventRecordWriter.kt 100.00% <100.00%> (ø)
...in/kotlin/com/datadog/android/flags/FlagsClient.kt 36.67% <33.33%> (+0.14%) ⬆️
...tadog/android/flags/internal/DatadogFlagsClient.kt 88.83% <67.86%> (-2.53%) ⬇️
...tadog/android/flags/internal/EvaluationsFeature.kt 18.87% <2.44%> (-56.13%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@typotter typotter force-pushed the typo/FFL-1720-pr2-aggregation branch from 141cded to 4bfc37e Compare January 28, 2026 16:33
@typotter typotter force-pushed the typo/FFL-1720-pr3-storage-network branch from 4f4c253 to df51ceb Compare January 28, 2026 16:35
@typotter typotter force-pushed the typo/FFL-1720-pr2-aggregation branch from 4bfc37e to 550f9f0 Compare January 28, 2026 17:05
@typotter typotter force-pushed the typo/FFL-1720-pr3-storage-network branch from 3618528 to cce61c1 Compare January 28, 2026 23:04
@typotter typotter marked this pull request as ready for review January 29, 2026 05:56
@typotter typotter requested a review from a team as a code owner January 29, 2026 05:56
@typotter typotter mentioned this pull request Jan 30, 2026
3 tasks
@typotter typotter force-pushed the typo/FFL-1720-pr3-storage-network branch from 8ade2db to c095d0d Compare February 13, 2026 15:10
Base automatically changed from typo/FFL-1720-pr2-aggregation to feature/flags-evaluations-logging February 13, 2026 15:33
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot dismissed stale reviews from 0xnm and dd-oleksii February 13, 2026 15:33

The base branch was changed.

0xnm
0xnm previously approved these changes Feb 13, 2026
[FFL-1720] Evaluation Logging: Integration

Wires the evaluation logging feature end-to-end by connecting the EvaluationsFeature to the flag evaluation flow. This is the final PR that enables evaluation logging in the Flags SDK.
@typotter
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Feb 13, 2026

View all feedbacks in Devflow UI.

2026-02-13 18:16:19 UTC ℹ️ Start processing command /merge


2026-02-13 18:16:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-13 22:18:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@typotter typotter merged commit d337d90 into feature/flags-evaluations-logging Feb 17, 2026
26 of 27 checks passed
@typotter typotter deleted the typo/FFL-1720-pr3-storage-network branch February 17, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants