refactor(go-forwarder): Tags struct to marshall properly#1105
Merged
ndakkoune merged 4 commits intonabil.dakkoune/go-forwarderfrom Apr 13, 2026
Merged
Conversation
ndakkoune
changed the title
ViBiOh
approved these changes
Apr 13, 2026
Comment on lines
+41
to
+47
| got, err := json.Marshal(tc.tags) | ||
| if err != nil { | ||
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| if string(got) != tc.want { | ||
| t.Errorf("got %s, want %s", got, tc.want) | ||
| } |
Contributor
There was a problem hiding this comment.
💬 suggestion: You can test the marshal/unmarshal cycle by doing both during the test.
If you marshal, then unmarshal, you should have an equal slice in the output.
ndakkoune
added a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors / Adds the Tags struct to force the unmarshall to create a comma-separated string of
key:valuepairs, due to backend constraint.Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply