Skip to content

[K9VULN-14992] Use install-datadog-ci-github-action for datadog-ci install#54

Merged
piloulacdog merged 1 commit into
mainfrom
pierrelouis.lacorte/K9VULN-14992-datadog-ci-github-action
May 19, 2026
Merged

[K9VULN-14992] Use install-datadog-ci-github-action for datadog-ci install#54
piloulacdog merged 1 commit into
mainfrom
pierrelouis.lacorte/K9VULN-14992-datadog-ci-github-action

Conversation

@piloulacdog
Copy link
Copy Markdown
Contributor

@piloulacdog piloulacdog commented May 18, 2026

🚀 Motivation

Per the datadog-ci team's feedback, this action's bespoke datadog-ci installer (curl + checksum + chmod, ~43 lines) duplicates work that the official DataDog/install-datadog-ci-github-action already handles. Adopting it reduces maintenance cost, lets future upstream datadog-ci fixes reach users automatically, and closes GitHub issue #49.

📝 Summary

  • Replaced the "Install datadog-ci" step in action.yml with uses: DataDog/install-datadog-ci-github-action@6d7f0c7c5402a4b1912055b76970ca76bef71fe5 # v1.0.4, pinning version: v5.12.1 to match current behavior.

🚧 Staging validation

🆘 Recovery

Notes for on-call - select only one:

  • The change can be rolled back.
  • Do not roll back. Why?:

Comment thread action.yml

case "$RUNNER_ARCH" in
X64) SBOMGEN_ARCH="amd64" ; DDCI_ARCH="x64" ;;
ARM64) SBOMGEN_ARCH="arm64" ; DDCI_ARCH="arm64" ;;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed DDCI_OS / DDCI_ARCH env exports (no longer needed: the upstream action resolves its own platform); the Windows arch guard now reads $RUNNER_ARCH directly.

Comment thread action.yml

echo "Uploading results to Datadog"
"$DDCI_PATH" sbom upload --source github-action --service datadog-sbom-generator --env ci "$OUTPUT_FILE" || exit 1
datadog-ci sbom upload --source github-action --service datadog-sbom-generator --env ci "$OUTPUT_FILE" || exit 1
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SBOM upload step now invokes datadog-ci directly (the upstream action puts the binary on $GITHUB_PATH) instead of $DDCI_PATH.

@piloulacdog piloulacdog changed the title [draft] [K9VULN-14992] Use install-datadog-ci-github-action for datadog-ci install May 18, 2026
@piloulacdog piloulacdog marked this pull request as ready for review May 18, 2026 15:19
@piloulacdog piloulacdog requested a review from a team as a code owner May 18, 2026 15:19
@piloulacdog piloulacdog merged commit 76d4b22 into main May 19, 2026
5 checks passed
@piloulacdog piloulacdog deleted the pierrelouis.lacorte/K9VULN-14992-datadog-ci-github-action branch May 19, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants