Closed
Conversation
…fields The Datadog API returns "" instead of null for unset threshold values on some monitor types (e.g. service check monitors, composite monitors). The deserializer only guarded against null, causing a serde panic: invalid type: string "", expected f64 Apply the same null-skip guard to all six threshold fields: critical, critical_recovery, ok, unknown, warning, warning_recovery. Reproducer: call ListMonitors on an org that has service-check monitors with unset warning/critical_recovery thresholds.
…into template Instead of fixing the generated code directly (which gets overwritten on spec changes), update model_simple.j2 to emit the null/empty-string check for all `number` type fields. This ensures the fix survives regeneration and applies consistently across all numeric fields in v1 and v2 models. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The previous template incorrectly skipped null values for ALL number fields. For nullable fields, null is a valid value (e.g. `error_budget_remaining: null`) and must be preserved as `Some(None)`. - Non-nullable, non-required number fields: skip null AND empty-string - Nullable number fields: skip only empty-string, preserve null - All other fields: unchanged behavior Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing if we can run the tests for #1292