Skip to content

Comments

Fix undo path parameters being passed with JSON string quotes#3197

Merged
nogates merged 1 commit intomasterfrom
nogates/undo-path-parameter-json-encoding
Feb 18, 2026
Merged

Fix undo path parameters being passed with JSON string quotes#3197
nogates merged 1 commit intomasterfrom
nogates/undo-path-parameter-json-encoding

Conversation

@nogates
Copy link
Contributor

@nogates nogates commented Feb 18, 2026

Summary

  • Fixed request_parameter_with_value in tests/conftest.py storing raw JSON-encoded values (with surrounding quotes) in path_parameters
  • When undo operations used these values as URL path segments, the quotes got URL-encoded as %22, causing VCR cassette path mismatches
  • Applied json.loads() to deserialize the value before storing, matching how request_parameter (the "from" variant) already handles this correctly

Test plan

  • All 5 previously failing Google Chat Integration organization handle tests now pass
  • Full test suite passes (1408 passed, 1537 skipped)

🤖 Generated with Claude Code

The `request_parameter_with_value` step stored raw JSON-encoded values
(e.g., `"uuid"` with quotes) into `path_parameters`. When undo operations
used these values, the quotes got URL-encoded as `%22`, causing VCR
cassette path mismatches. Deserialize with `json.loads()` before storing
to match how `request_parameter` already handles this correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nogates nogates merged commit 94a89c8 into master Feb 18, 2026
17 of 18 checks passed
@nogates nogates deleted the nogates/undo-path-parameter-json-encoding branch February 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants