Allow passing version name via environmental variable to apps plugin#272
Merged
yoannmoinet merged 1 commit intomasterfrom Feb 20, 2026
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
oliverli
force-pushed
the
oliver/allow-passing-version-name-via-environmental-variable-to-apps-plugin
branch
from
da2826c to
a6d0bae
Compare
Collaborator
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6d0bae0df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
yoannmoinet
reviewed
Feb 19, 2026
Member
yoannmoinet
left a comment
yoannmoinet
left a comment
There was a problem hiding this comment.
I don't think we need to define it in validatedOptions, but only check for it at the very end.
Let me know if there actually is a reason for it.
oliverli
force-pushed
the
oliver/allow-passing-version-name-via-environmental-variable-to-apps-plugin
branch
from
a6d0bae to
008e24b
Compare
yoannmoinet
deleted the
oliver/allow-passing-version-name-via-environmental-variable-to-apps-plugin
branch
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: done
and removed
mergequeue-status: waiting
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Updates the apps plugin to take in an optional version name via the
DATADOG_APPS_VERSION_NAMEenvironmental variable when uploading app assets.The intent is to use this variable name in CI (setting it to the Git commit SHA) to identify each version that is uploaded.
If unspecified, defaults to server generated version names.
How?
Updated
getDatato fetch theDATADOG_APPS_VERSION_NAMEenvironmental variable, setting it in the multipart form if present