Skip to content

Optimise rspack/webpack chunk collection with Set deduplication #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoannmoinet merged 2 commits into from
Feb 17, 2026
Merged

Optimise rspack/webpack chunk collection with Set deduplication #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c16c855
Use Set for chunk deduplication in rspack/webpack build report
yoannmoinet Feb 17, 2026
60f2513
Merge branch 'master' into yoann/optimise-rspack-chunks
yoannmoinet Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/plugins/build-report/src/xpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,17 +436,20 @@ export const getXpackPlugin =
// eslint-disable-next-line @typescript-eslint/no-explicit-any
chunkGroup: any,
visited: Set<unknown> = new Set(),
): Chunk[] => {
): Set<Chunk> => {
if (visited.has(chunkGroup)) {
return [];
return new Set();
}
visited.add(chunkGroup);

const allChunks: Chunk[] = [...chunkGroup.chunks];
const allChunks: Set<Chunk> = new Set(chunkGroup.chunks);

// Recursively get chunks from child chunk groups (async chunks).
for (const childGroup of chunkGroup.childrenIterable || []) {
allChunks.push(...getAllChunksFromGroup(childGroup, visited));
const childChunks = getAllChunksFromGroup(childGroup, visited);
for (const chunk of childChunks) {
allChunks.add(chunk);
}
}

return allChunks;
Expand All @@ -458,7 +461,7 @@ export const getXpackPlugin =
let size = 0;
// Get all chunks including async chunks from child chunk groups.
const allChunks = getAllChunksFromGroup(entrypoint);
const entryFiles = allChunks.flatMap(getChunkFiles);
const entryFiles = Array.from(allChunks).flatMap(getChunkFiles);

// FIXME This is not a 100% reliable way to get the entry filename.
const entryFilename = entrypoint.chunks
Expand Down
Loading