Skip to content

wasm plugin - #5006

Draft
BenoitZugmeyer wants to merge 14 commits into
mainfrom
benoit/push-wykrxolrskzy
Draft

wasm plugin#5006
BenoitZugmeyer wants to merge 14 commits into
mainfrom
benoit/push-wykrxolrskzy

Conversation

@BenoitZugmeyer

Copy link
Copy Markdown
Member

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

ImaneLargou and others added 13 commits July 27, 2026 14:10
Intercepts WebAssembly.instantiate / instantiateStreaming at SDK
script-load time to record (url, build_id) per loaded module, including
lazily-loaded modules. On error capture, attaches error.wasm_modules[]
and sets source_type='browser+wasm' so the backend can dispatch wasm
symbolication.

- New wasmModules/wasmModuleTracking.ts: hooks all four WebAssembly
  entry points; reads build_id via a minimal custom-section parser;
  registry stays live for lazy module loads
- New wasmModules/wasmBinaryParser.ts: walks wasm binary sections,
  extracts build_id custom section or falls back to external_debug_info
- errorCollection: populates error.wasm_modules[] and flips source_type
  to 'browser+wasm' when any module is registered
- rawRumEvent.types: adds wasm_modules?: Array<{url, build_id}> to
  RawRumErrorEvent
- main.ts: installs tracking synchronously at script-load time to close
  the race window before DD_RUM.init()'s deferred microtask

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-experiment

# Conflicts:
#	package.json
#	packages/browser-core/src/domain/telemetry/telemetryEvent.types.ts
#	yarn.lock
…-experiment

# Conflicts:
#	package.json
#	packages/browser-logs/src/domain/runtimeError/runtimeErrorCollection.spec.ts
#	packages/browser-logs/src/rawLogsEvent.types.ts
#	yarn.lock
@BenoitZugmeyer BenoitZugmeyer changed the title Benoit/push wykrxolrskzy wasm plugin Sep 2, 2026
@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Sep 2, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

Lint PR title | lint — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

The lockfile would have been modified by this install, which is explicitly forbidden.

DataDog/browser-sdk | build-and-lint

View more details · View in GitLab

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/main HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: benoit/push-wykrxolrskzy

Lint PR title | lint
Commit: af63b9705b74e3a6b5b446cc72aee5184451b880
Error (code / build):
The lockfile would have been modified by this install, which is explicitly forbidden.
CI job: https://github.com/DataDog/browser-sdk/actions/runs/33641717185/job/100286172073

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 77.33%
Overall Coverage: 77.02% (-0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: af63b97 | Docs | View more details | Give us feedback!

@BenoitZugmeyer
BenoitZugmeyer force-pushed the benoit/push-wykrxolrskzy branch from 89e9868 to 8be692f Compare September 2, 2026 14:08
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 181.63 KiB 181.69 KiB +69 B +0.04%
Rum Profiler 8.43 KiB 8.43 KiB 0 B 0.00%
Rum Recorder 25.32 KiB 25.32 KiB 0 B 0.00%
Logs 57.93 KiB 58.49 KiB +577 B +0.97%
Rum Salesforce N/A 139.74 KiB N/A N/A N/A
Rum Slim 139.68 KiB 139.73 KiB +49 B +0.03%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%
Rum Shopify N/A 206.06 KiB N/A N/A N/A
Rum-shopify Profiler N/A 8.43 KiB N/A N/A N/A
Rum-shopify Recorder N/A 3.74 KiB N/A N/A N/A

@BenoitZugmeyer
BenoitZugmeyer force-pushed the benoit/push-wykrxolrskzy branch from 8be692f to af63b97 Compare September 2, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants