Skip to content

Conversation

@tonyredondo tonyredondo marked this pull request as ready for review November 29, 2024 13:31
@tonyredondo tonyredondo requested review from a team as code owners November 29, 2024 13:31
.gitlab-ci.yml Outdated
# Retrieve common go deps
- mkdir -p $GOPATH/pkg/mod && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod && rm -f modcache_e2e.tar.xz
# Install orchestrion
- go install github.com/DataDog/orchestrion@v0.9.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought
We could install orchestrion in our e2e runner image, defined in `test-infra-definitions. Can be a follow up and we can handle it

Copy link
Member Author

@tonyredondo tonyredondo Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can do that, just keep in mind that v0.9.4 is an non GA version. Currently the stable version requires a recent Go version (>= 1.22.9) so it must be in sync with the Go version you are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants