-
Notifications
You must be signed in to change notification settings - Fork 47
0.5.2 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeterSu92
wants to merge
16
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modern NVIDIA GPUs with a special case for using boot disk images that already have the GPU drivers installed
Updating dev branch (0.5.0) with changes in main (0.5.1)
…, removed if conditional
…, and location environment variables
porting over changes from verily-src/dsub 0.5.2
jupyter if unset. test_setup.sh updated to use env variables rather than hardcoded network settings
…network and SA values
…w integration test files and use that directly
johntbates
approved these changes
Jan 22, 2026
Contributor
johntbates
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a couple of minor nits here - nothing too serious.
johntbates
approved these changes
Jan 30, 2026
Contributor
johntbates
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a couple of fixes to get some more tests to pass - right now, 5 tests are still failing using the
google-batchprovider, but these also fail onmainThe following summary was generated with the help of Claude Code:
Overview
Branch: 0.5.2_dev
Provider: google-batch
Environment: Jupyter on Workbench (VPC-SC)
Results: 38 passed, 5 failed (out of 43 tests)
Failing Tests (5)
Important: All 5 failing tests also failed on 0.5.1/main branch. These are not regressions from 0.5.2 changes.
e2e_image.shValueError: --use-private-address must specify a --image with a gcr.io or pkg.dev hostbash:4.4,python:2-slim,python:3-slim) which can't be pulled with--use-private-addressin VPC-SC environmentse2e_verify_failure_log.shdstat_output: unbound variable(line 46)e2e_python_api.pyJobExecutionErrore2e_non_root.shJobExecutionErrore2e_requester_pays_buckets.shJobExecutionErrorTest Fixes Applied in This Branch
1. USER Variable Fix
Several tests failed with
USER: unbound variablein bash strict mode. Fixed by setting default:Files modified:
test/integration/io_setup.sh-${USER}→${USER:-jupyter}test/integration/io_tasks_setup.sh-${USER}→${USER:-jupyter}test/integration/e2e_logging_paths.sh-${USER}→${USER:-jupyter}test/integration/e2e_logging_paths_pattern_tasks.sh-${USER}→${USER:-jupyter}test/integration/test_setup.sh- Addedexport USER="${USER:-jupyter}"2. Python Test Setup Fix
Python tests (
e2e_*.py) were missing--service-accountand had hardcoded network settings.File modified:
test/integration/test_setup_e2e.pyGPU_NETWORK,GPU_SUBNETWORK,LOCATION,PET_SA_EMAILenvironment variables--service-accountflag whenPET_SA_EMAILis set3. Shell Test Setup Fix
Shell tests had hardcoded network settings that didn't work in VPC-SC.
File modified:
test/integration/test_setup.shGPU_NETWORK,GPU_SUBNETWORK,PET_SA_EMAIL,LOCATIONenvironment variablesVPC-SC Limitations
The following tests are expected to fail in VPC-SC environments:
e2e_image.sh- Uses public Docker Hub images which cannot be pulled when--use-private-addressis enabled. VPC-SC environments block access to public container registries.Any test using non-gcr.io/pkg.dev images - The
--use-private-addressflag requires images from Google Container Registry (gcr.io) or Artifact Registry (pkg.dev).Comparison to Previous Runs
| Run | Total | Passed | Failed | Notes |
| After cleanup fix | 43 | 38 | 5 | Current state |
Current explanations for the failing tests:
e2e_verify_failure_log.sh- Fix the unbound variable bug (pre-existing issue, separate PR)e2e_image.sh- Document as expected failure in VPC-SC, or mirror test images to GARJob execution failures (
e2e_python_api.py,e2e_non_root.sh,e2e_requester_pays_buckets.sh) - Investigate root cause, but these appear to be environmental rather than code issues