feat: integrate email doctor checks into flow doctor #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conditional EMAIL section to `flow doctor` that checks himalaya and all email dependencies when the `em` dispatcher is loaded. - Phase 1: _doctor_check_email() with himalaya (required+version), HTML renderer (any-of w3m/lynx/pandoc), glow, email-oauth2-proxy, terminal-notifier, AI backend checks + config summary - Phase 2: Email category in --fix mode menu with brew/pip install - Phase 3: _doctor_email_connectivity() for --verbose mode (IMAP, OAuth2 proxy, SMTP config validation with 5s timeouts) - Phase 4: _doctor_email_setup() guided config wizard with provider auto-detection (Gmail, Outlook, Yahoo, iCloud) and OAuth2 guidance - Phase 5: Updated _doctor_help() with EMAIL section docs - Phase 6: 13 tests in test-doctor-email.zsh (all passing) Zero overhead when em() not loaded. Existing 22 doctor tests pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
20 tests across 8 categories: output structure, section ordering, dep dedup, mode combinations, missing dep simulation (PATH manipulation), fix mode menu, em doctor independence, and config env overrides. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix zsh "bad output format specification" crash in
_doctor_select_fix_category — the ${[[ ... ]]} inline plural
pattern is invalid inside associative array assignments.
Replace with pre-computed suffix variables.
Add 23 interactive headless tests covering:
- _doctor_confirm yes/no/empty branching
- _doctor_select_fix_category menu selection
- _doctor_fix_email with fake brew/pip
- _doctor_email_setup wizard (Gmail, custom, cancel)
- --fix -y end-to-end auto-yes bypass
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- doctor.md: EMAIL dep table, verbose connectivity, fix mode email category, guided setup wizard, updated key functions + see also - REFCARD-DOCTOR.md: EMAIL category (#6), email in fix menu, --yes flag, email integration entry, updated version - CHANGELOG.md: v7.0.2 entry for email doctor integration feature Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace last $([[ ... ]]) inline plural pattern at line 476 with pre-computed suffix variable, matching the safe pattern used at lines 561, 571, 586, 595. Remove ORCHESTRATE-em-doctor-integration.md session artifact from repo root. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Data-Wise
pushed a commit
that referenced
this pull request
Feb 12, 2026
Update What's New banner, footer version, QUICK-REFERENCE version, and CLAUDE.md status to v7.0.2 following PR #379 merge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
flow doctor— when theemdispatcher is loaded, checks himalaya (required, version >= 1.0.0), w3m/lynx/pandoc (any-of), glow, email-oauth2-proxy, terminal-notifier, and AI backend (claude/gemini) with config summaryflow doctor --fixincludes "Email Tools" with brew + pip install support and guided himalaya setup wizard (provider auto-detection for Gmail/Outlook/Yahoo/iCloud)flow doctor --verboseruns IMAP ping, OAuth2 proxy status, and SMTP config validation (5s timeout per test)_doctor_select_fix_categorycrash —${[[ ... ]]}inline plural pattern inside associative array assignments caused segfault; replaced with pre-computed suffix variablesTest plan
flow.plugin.zshloads cleanly🤖 Generated with Claude Code