Skip to content

Probe the Codex sandbox before coding and declare environment skips (#403) - #407

Merged
DanielNetzer merged 1 commit into
mainfrom
forgecell/issue-403-9e8d280afda245d15f0dd812
Nov 8, 2026
Merged

DanielNetzer merged 1 commit into
mainfrom
forgecell/issue-403-9e8d280afda245d15f0dd812

Conversation

@DanielNetzer

Copy link
Copy Markdown
Owner

Implements issue #403.

Molecule: mol-403-5e0af62179c7cb56a75b9b2b
Formula: forgecell-github-issue
Base: b15771e5445918c93d2ab63f25aa9bcd37289901
Delivery: 02c12c06591e9ee4804a9b3c011b714842f387ac

Awaiting exact-commit CI and human review. Harness-reported checks are not independent CI evidence. No merge, deployment or issue closure is authorized.

@DanielNetzer

Copy link
Copy Markdown
Owner Author

Notes:

  • Review fix (HIGH, fixed in this slice): the first version passed --add-dir and -C to codex sandbox. Codex 0.167.0 rejects both: unexpected argument '--add-dir', and -C requires --permission-profile. So every real probe would have been recorded as unavailable. The probe now uses -c sandbox_workspace_write.writable_roots=[…] and the shell_environment_policy.set overrides, and it runs with the workspace as its working directory. A test pins the argument list. Run by hand through the real codex sandbox with this branch's script, it printed workspace-write=ok harness-cache-write=ok spawn=ok ps=denied localhost-bind=denied.
  • Plan reordered (revision 3): the regression checks were reordered by cost to work around --accept-protected-failures refuses when a costlier regression check comes first in the plan #406, where --accept-protected-failures refuses when a costlier regression check comes first in the plan. No check changed.
  • Protected regression, accepted by design: TestAdapterInvocationChangesRequireProtocolBump, which has no pin for protocol 11.
  • Scope note: the local-socket test skips were dropped from this slice (see the Issue); only the ps test uses testenv.SkipIfSandboxDenies.
  • Protocol 11: saved bindings need a reviewed rebind after upgrading.

All required checks passed.

@DanielNetzer
DanielNetzer marked this pull request as ready for review November 8, 2026 02:09
@DanielNetzer
DanielNetzer merged commit a666cbe into main Nov 8, 2026
2 checks passed
@DanielNetzer
DanielNetzer deleted the forgecell/issue-403-9e8d280afda245d15f0dd812 branch November 8, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant