Resolve workspace aliases case-insensitively - #60
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
Implicit next/briefing and console overview omit a colliding --workspace selector (CLI uses --root). Console plan and apply share get_workspace so unique fold prints the canonical name and twins fail closed on both dry-run and apply. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
Create a line without publishing origin so implicit JSON next hits repair commands and asserts those fields, not a false-green ready or needs_line path. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
When overview blanks recommendation.command on fold-twin cards, the operator copy path must not invent `dyro --workspace <alias> doctor`. Unique-alias ads still pass through a backend-provided command. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/workspace-alias-casefold-a695
branch
from
August 22, 2026 20:46
67b3b5f to
c245547
Compare
The operator copy-path change edited packaged app.js without updating ASSET_MANIFEST, so validate_assets fail-closed and CI could not start the Console shell. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third-review P1 on the same branch. Rebased onto
mainafter #59 and #61 (0d71a59). No version bump (0.7.10).P1 this revision
src/dyro/console/assets/app.js:recommendedCommandno longer inventsdyro --workspace <alias> doctorwhen overview leftrecommendation.commandblank (fold-twin FAIL cards). Unique-alias--workspaceads still pass through a backend-provided command.primary-copy/recommendedCommand), not only the JSON field: FAIL+empty under fold collision does not invent--workspace … doctor.src/dyro/console/assets.py:ASSET_MANIFESTpin forapp.jsupdated (fail-closed static shell).Still fixed / do not regress
--workspaceselector; colliding profile names use--root. Unique keeps canonical--workspace.workspace default/workspace removeplan and apply share resolve; remove can still target each exact registered name when twins collidecli.py:cmd_consoledry-run and apply shareget_workspace(canonical unique fold; fail-closed collision)--workspacead (empty command;IsolatedOverviewService._safe_commandaccepts omit)Rebase
Preserved this PR’s scoped ads and #61’s
ReadBudget/deadline_repair_commands.next_step.py:deadline_repair_commandsfallbacks usescoped_briefing_commandwhen a config is available.Leave unmerged.