feat: carry NPC conversation session context#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversation_session_idandtrigger_event_idfrom Unity NPC decision requests into Nakama.Why
NPC chat was model-backed, but each model decision could still feel stateless. This patch makes the current Nakama conversation session part of the prompt, so follow-up questions can reference what was just said instead of sounding like a fresh call.
Safety
Local Code Review Fallback
Verdict: APPROVED.
Verification
conversation_sessionwas missing from the DOS.AI prompt.npm.cmd run buildinbackend/nakamanpm.cmd testinbackend/nakamagit diff --check --cachedVerification Note
dotnet build Unity\SecondSpawn.AI.csprojcould not be completed inside the isolated worktree because Unity-generated project files andLibrarypackage assemblies are ignored and not present there. Copying.csprojfiles locally still left Unity package references such asUnity.InputSystemunresolved. The C# change is limited to adding DTO string fields and assigning existing string values; Unity compile should be checked from the main Unity checkout or Editor after merge.Unrelated Files Left Out
The worktree has a generated knowledge-pack line-ending touch from
npm run build; it is intentionally not staged.