Skip to content

fix: surface NPC dialog response lifecycle#101

Merged
JOY (JOY) merged 1 commit into
devfrom
codex/npc-dialog-lifecycle
May 20, 2026
Merged

fix: surface NPC dialog response lifecycle#101
JOY (JOY) merged 1 commit into
devfrom
codex/npc-dialog-lifecycle

Conversation

@JOY
Copy link
Copy Markdown
Contributor

Summary

  • Add focused NPC response lifecycle callbacks from PrototypeAgentBrain to the UGUI chat panel.
  • Show waiting/retry status while the NPC is contacting DOS.AI.
  • Add a clear system line when a focused NPC exhausts bounded DOS.AI retry attempts.
  • Update ROADMAP and CHANGELOG.

Local code review

Verdict: APPROVED WITH SUGGESTIONS.

Notes:

  • No authority regression found. The lifecycle callbacks only update local UI state.
  • No client key exposure found.
  • Suggestion for a later PR: migrate the legacy IMGUI chat debug panel or remove it once UGUI is fully accepted. The new system lifecycle line is only rendered by UGUI, which is the default panel.

Verification

  • npm.cmd install in backend/nakama
  • npm.cmd run build in backend/nakama
  • npm.cmd test in backend/nakama
  • dotnet build Unity\SecondSpawn.AI.csproj
  • dotnet build Unity\SecondSpawn.UI.csproj
  • npx.cmd markdownlint-cli2 ROADMAP.md CHANGELOG.md
  • git diff --check
  • em dash scan on changed files

@JOY JOY (JOY) merged commit 89f08c7 into dev May 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant