Repository navigation
fix(importer,web): plan v7 section 5 code fixes - #3
Merged
Merged
Conversation
Implements section 5 of the approved Rate domain plan v7 (Codex APPROVED-WITH-NOTES after 7 adversarial rounds, Gemini APPROVED; schema half merged in DOS-Me PR #1027): - entity-matcher: Tier 1/2 infra errors abort ingestion (no silent cluster split); Tier 3 insert-only + winner refetch; fuzzy below 0.70 and unparseable identities seed as draft, never auto-published - product-normalizer: deterministic RAM-word matching - every RAM phrase claims its adjacent size token, the single unclaimed remainder is storage, ambiguity keeps ':unknown' identity + draft; ROM/bo-nho-trong markers beat RAM phrases, loose 'dung luong' keeps a RAM-phrase lookahead; decimal comma accepted. 18/18 regression cases incl. all Codex probes - shopee-to-supabase: idempotent price_history via listing-scoped observation_id (client-side dedupe - partial index cannot take ON CONFLICT); stable review observation ids without createdAt; review writes dedupe in-batch and fail ingestion on error - rate-api: fail hard on missing env, throw on query errors, review_flags verdicts embedded for UI badges, published-only reads Dependency: price_history.observation_id + review_flags live in DOS-Me migrations 20261005130000/130001 (propagating beta->prod); missing schema fails hard by design.
JOY (JOY)
force-pushed
the
feat/importer-plan-s5-fixes
branch
from
October 6, 2026 03:17
4e3fc84 to
fe5e2a9
Compare
JOY (JOY)
pushed a commit
that referenced
this pull request
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements section 5 (code-side fixes) of the approved Rate domain plan (Docs/Proposals/2026-10-04-rate-domain-migration-plan.md, Codex APPROVED-WITH-NOTES + Gemini APPROVED after 7 adversarial rounds). The schema half of the plan is already merged in DOS-Me PR #1027.
Verification