Conversation
aldbr
requested changes
Feb 24, 2026
Contributor
aldbr
left a comment
aldbr
left a comment
There was a problem hiding this comment.
This change looks interesting. Any reason for not finishing it?
| router = DiracxRouter(require_auth=False, path_root="") | ||
|
|
||
|
|
||
| _static_cache: TTLCache = TTLCache(maxsize=5, ttl=60) |
Contributor
There was a problem hiding this comment.
Why maxsize=5?
IIUC, we would need at least maxsize=2 here, 4 looks generous enough (to keep the old and new entries for a brief moment?), right?
And the ttl could be a bit longer I guess.
Suggested change
| _static_cache: TTLCache = TTLCache(maxsize=5, ttl=60) | |
| _static_cache: TTLCache = TTLCache(maxsize=4, ttl=300) |
| """Get metadata about the dirac installation.""" | ||
| return await get_installation_metadata_bl(config) | ||
| cached_hash = f"dirac-metadata:{config._hexsha}" | ||
| if cached_hash not in _static_cache: |
Contributor
There was a problem hiding this comment.
Note: I think extensions like gubbins could also benefit from the cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.