fix(db,routers): improve DB URLs error handling - #1034
Open
francescobrivio wants to merge 1 commit into
Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
In this PR I'm improving the error reporting when DB_URL env variables are missing as suggested in the "Proposed Changes" section of #46.
PR Validation
Manually tweaking
BaseSQLDB.available_urls()andBaseOSDB.available_urls()I was able to generate the desired warning messages:Additionally, manually tweaking
diracx-db/src/diracx/db/__main__.py.generate_local_urls()I was able to reproduce the desired error messages:DoD
Closes #46