feat: UploadLogFile command implementation#97
Draft
AcquaDiGiorgio wants to merge 5 commits intoDIRACGrid:mainfrom
Draft
feat: UploadLogFile command implementation#97AcquaDiGiorgio wants to merge 5 commits intoDIRACGrid:mainfrom
AcquaDiGiorgio wants to merge 5 commits intoDIRACGrid:mainfrom
Conversation
4 tasks
Contributor
Author
|
There is an issue with the FailoverRequest. |
First approach, needs review
Improve UploadLogFile tests
AcquaDiGiorgio
had a problem deploying
to
github-pages
GitHub Actions
Failure
AcquaDiGiorgio
had a problem deploying
to
github-pages
GitHub Actions
Failure
AcquaDiGiorgio
force-pushed
the
issue-87-LHCb-UploadLogFile
branch
from
c3f5c70 to
93cb40c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #87
First approach, needs review.
I tried to use the current Mock classes (MockDataManager), but I don't think this is the correct way. However, it should not vary much.
I open it as a draft because I still need to create 2 more tests and change the interactions with DIRAC.