Skip to content

fix: adding the owner-write bit to bundled files #8541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fstagni wants to merge 1 commit into
base: integration
Choose a base branch
from
+8 −1
Open

fix: adding the owner-write bit to bundled files #8541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/DIRAC/FrameworkSystem/Service/BundleDeliveryHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,16 @@ def updateBundles(self):
Path(os.path.commonpath(paths)).parent if len(paths) == 1 else Path(os.path.commonpath(paths))
)
gLogger.info(f"Bundle will have {len(filesToBundle)} files with common path {commonParent}")

def _makeWritable(tarinfo):
# Ensure files are extracted as writable so subsequent syncs can overwrite them.
# by setting the owner-write bit (0o200)
tarinfo.mode |= 0o200
return tarinfo

with tarfile.open("dummy", "w:gz", buffer_) as tarBuffer:
for p in paths:
tarBuffer.add(str(p), str(p.relative_to(commonParent)))
tarBuffer.add(str(p), str(p.relative_to(commonParent)), filter=_makeWritable)
zippedData = buffer_.getvalue()
buffer_.close()
hash_ = File.getMD5ForFiles(filesToBundle)
Expand Down
Loading