Prevent CameraPreview toolbar clipping on compact screens - #920
Open
Vetle444 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an iOS compact-screen layout issue in CameraPreview where custom bottom toolbar content could be clipped by allowing the bottom toolbar container to grow to its natural height while still reserving the computed letterbox height as a minimum. It also updates zoom/overlay offset calculations to respect the toolbar’s rendered height and adds a regression unit test for the measured iPhone SE layout case.
Changes:
- Update
CameraPreviewto set a minimum bottom toolbar height (letterbox) instead of a fixedHeightRequest, allowing content-driven growth. - Ensure zoom control margin and overlay offset calculations use the effective bottom toolbar height.
- Add a compact-screen regression unit test and document the fix in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/library/DIPS.Mobile.UI/API/Camera/Preview/CameraPreview.cs |
Allows bottom toolbar to expand beyond the letterbox minimum and updates dependent offsets/margins accordingly. |
src/tests/unittests/API/Camera/Preview/CameraPreviewTests.cs |
Adds a compact-screen regression test based on iPhone SE measurements. |
CHANGELOG.md |
Adds a patch-note entry describing the CameraPreview clipping fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Addresses Arena.Mobile #2053.
CameraPreviewbottom toolbar content to grow to its natural height while preserving the calculated letterbox height as its minimum.Todos