Release: develop -> main#3797
Merged
Merged
Conversation
* feat(gs): add ALL_TRACES template for generic log queries Adds a new /gs/debug/logs template that returns all trace entries in the requested time window without a messageFilter. Default limit 500. Self-emitted audit lines from /gs/debug/logs (prefix "[GsService] Log query by ") are filtered at the template level to prevent the audit feedback loop that would otherwise dominate the result for any high-frequency caller (e.g. the upcoming all-logs dashboard view in DFXswiss/services). * refactor(gs): extract LogQueryAuditPrefix to break implicit string contract The TRACES self-filter in the new ALL_TRACES template hardcoded the audit-log prefix emitted by gs.service.executeLogQuery. A refactor of either string would have silently broken the filter. Both sides now reference a shared LogQueryAuditPrefix constant from gs.dto.ts. The new spec verifies that the audit log and the template KQL stay in sync. * docs(gs): note class-name coupling in LogQueryAuditPrefix
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
The repo runs on PostgreSQL (src/config/config.ts:218: type: 'postgres'), so the entity examples and rules now match the dialect actually in use: - 'text' for unlimited-length strings (89 occurrences in src/, replacing the previous MSSQL 'length: MAX' idiom which is no longer used) - 'timestamp' for date columns (87 occurrences in src/, replacing the previous MSSQL 'datetime2')
* [NOTASK] KycSteps ident review required * [NOTASK] Refactoring * [NOTASK] Renaming
* feat(dashboard): restrict financial log queries to valid rows Filter getLatestFinancialLog and getFinancialLogs (both daily-sample and full branches) to rows with valid = true. The financial log writer flags a row as valid when the total-balance delta to the previous log is within the configured limit, so the financial-overview charts now skip spike/glitch snapshots. * fix(dashboard): keep getLatestFinancialLog unfiltered The latest-balance endpoint feeds the Total/Plus/Minus/Timestamp cards on the financial-overview screen, which must always reflect the newest log entry regardless of valid. Restrict the valid = true filter to getFinancialLogs (long time-series chart) only. * docs(log): note numeric vs chart filtering convention
* docs(scrypt): check in vendor AsyncAPI spec as reference
The Scrypt integration is built against a non-public WebSocket API that
sits behind HTTP Basic Auth at doc.client.scrypt.swiss. Add the rendered
AsyncAPI 3.0 spec to src/integration/exchange/docs/ so the spec is
discoverable next to the integration code and survives without depending
on continued access to the vendor portal.
The README captures source URL, fetch date, refresh procedure, and the
three non-obvious facts that drive integration choices: Fee="0" defaults,
AvgPx exclusion of fees, and RFQ TradedPx all-in semantics.
* docs(scrypt): add FIX API PDF + document FIX/WebSocket divergences
Companion to the AsyncAPI WebSocket spec. The FIX API documents
features that are not exposed (or not documented) over WebSocket —
notably:
- OrdType A = LimitAllIn, where the LIMIT price already includes
fees. If Scrypt accepts this over WebSocket too, it is the
cleanest way to bound implicit commission cost.
- CumFee (Tag 4016) in ExecutionReport — cumulative fee tracked
server-side.
- DecisionStatus (Tag 20032) for staged-order lifecycle.
- CancelOnDisconnect (Tag 20030) auto-cancel semantics.
- Order State Change Matrices (Filled / Canceled /
Replace-to-increase / Replace-during-fill).
Also enumerate known FIX-vs-WebSocket divergences in OrdType, ExecType,
and OrdRejReason enums so future contributors don't assume
cross-protocol parity.
PDF source URL kept in the README for re-fetch; the PDF itself is
publicly hosted, no auth needed.
TaprootFreak
approved these changes
Jun 2, 2026
davidleomay
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist