Release: develop -> main#3781
Merged
Merged
Conversation
…oney left (#3778) Scrypt deposit requests were sent at bank payment transmission time, before the money actually arrived. Scrypt then created pending deposits that could take >24h to reconcile. A cleanup cron marked them failed after 24h, racing against Scrypt's reconciliation and causing ~100k CHF double-count in the financial log. Move the Scrypt deposit notification from the transmit step to the searchOutgoingBankTx completion step, where the matching bank_tx confirms the money left. Remove the stale deposit cleanup cron — no longer needed.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
davidleomay
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist