fix: reject implausible temperature readings - #5
Merged
DF-wu merged 1 commit intoSep 24, 2026
Merged
Conversation
Restore the R730xd/iDRAC 8 hardware disclaimer, reject unsafe telemetry before fan decisions, and restore Dell automatic control after a partial IPMI write failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Field finding
A TrueNAS VM saw a VMware virtual NVMe SMART temperature of 11759 C. The prior controller accepted it and continuously selected the critical fan level. This patch treats such numeric-but-invalid telemetry as a failed reading, allowing other valid sources or the configured fail-safe to decide.
Verification
make test: 60 core assertions, 14 TUI assertionsgit diff --check