Support for non-opaque items/fluids. #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rubensworks
requested changes
Sep 27, 2021
Member
rubensworks
left a comment
rubensworks
left a comment
There was a problem hiding this comment.
Looks good in general!
I'll do a more detailed later, but in the meantime I already gave one comment on the level of abstraction of the new export tasks.
| String subKey = "fluid:" + location; | ||
| //Test if fluid is opaque | ||
| if (RenderTypeLookup.canRenderInLayer(fluidEntry.getValue().getDefaultState(), RenderType.getSolid())) { | ||
| exportTasks.add((matrixStack, bImage) -> { |
Member
There was a problem hiding this comment.
There's quite a bit of code duplication in these tasks. Could this be abstracted? Otherwise this significantly complicates maintenance effort in future updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.