-
-
Notifications
You must be signed in to change notification settings - Fork 93
Changed bom-ref to refId. Title and description updated. Updated test… #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.0-dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -36,10 +36,10 @@ | |||||
| "title": "Behavior Instance", | ||||||
| "description": "A behavior performed by one or more objects within the BOM.", | ||||||
| "additionalProperties": false, | ||||||
| "required": ["bom-ref", "behavior"], | ||||||
| "required": ["refId", "behavior"], | ||||||
| "properties": { | ||||||
| "bom-ref": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refType" | ||||||
| "refId": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refIdType" | ||||||
| }, | ||||||
| "behavior": { | ||||||
| "$ref": "../../behavior-taxonomy.schema.json", | ||||||
|
|
@@ -55,7 +55,7 @@ | |||||
| "actors": { | ||||||
| "type": "array", | ||||||
| "title": "Actors", | ||||||
| "description": "References using bom-link or bom-ref to objects that perform this behavior.", | ||||||
| "description": "References using bom-link or refId to objects that perform this behavior.", | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe out of scope but a good situation to do this:
Suggested change
Ir if not in scope, create a follow-up ticket from this comment. |
||||||
| "uniqueItems": true, | ||||||
| "items": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refLinkType" | ||||||
|
|
@@ -64,7 +64,7 @@ | |||||
| "targets": { | ||||||
| "type": "array", | ||||||
| "title": "Targets", | ||||||
| "description": "References using bom-link or bom-ref to objects affected by this behavior.", | ||||||
| "description": "References using bom-link or refId to objects affected by this behavior.", | ||||||
| "uniqueItems": true, | ||||||
| "items": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refLinkType" | ||||||
|
|
@@ -138,12 +138,12 @@ | |||||
| "description": "A graph of nodes joined by transitions that models behaviour over time. A node may be an activity, a state, an event, a gateway, or a start or end point, so the same construct expresses an activity or process flow (where the nodes are activities), a state machine (where the nodes are states), or a mixture of the two.", | ||||||
| "additionalProperties": false, | ||||||
| "required": [ | ||||||
| "bom-ref", | ||||||
| "refId", | ||||||
| "nodes" | ||||||
| ], | ||||||
| "properties": { | ||||||
| "bom-ref": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refType" | ||||||
| "refId": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refIdType" | ||||||
| }, | ||||||
| "name": { | ||||||
| "type": "string", | ||||||
|
|
@@ -172,7 +172,7 @@ | |||||
| "subject": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refLinkType", | ||||||
| "title": "Subject", | ||||||
| "description": "Reference using bom-link or bom-ref to the object whose behaviour this graph describes." | ||||||
| "description": "Reference using bom-link or refId to the object whose behaviour this graph describes." | ||||||
| }, | ||||||
| "acknowledgment": { | ||||||
| "$ref": "#/$defs/acknowledgment" | ||||||
|
|
@@ -241,12 +241,12 @@ | |||||
| "description": "A single node in a behavior graph. The kind determines what the node represents and which additional properties apply.", | ||||||
| "additionalProperties": false, | ||||||
| "required": [ | ||||||
| "bom-ref", | ||||||
| "refId", | ||||||
| "kind" | ||||||
| ], | ||||||
| "properties": { | ||||||
| "bom-ref": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refType" | ||||||
| "refId": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refIdType" | ||||||
| }, | ||||||
| "kind": { | ||||||
| "title": "Kind", | ||||||
|
|
@@ -302,7 +302,7 @@ | |||||
| "actors": { | ||||||
| "type": "array", | ||||||
| "title": "Actors", | ||||||
| "description": "References using bom-link or bom-ref to objects that perform this node.", | ||||||
| "description": "References using bom-link or refId to objects that perform this node.", | ||||||
| "uniqueItems": true, | ||||||
| "items": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refLinkType" | ||||||
|
|
@@ -311,7 +311,7 @@ | |||||
| "targets": { | ||||||
| "type": "array", | ||||||
| "title": "Targets", | ||||||
| "description": "References using bom-link or bom-ref to objects affected by this node.", | ||||||
| "description": "References using bom-link or refId to objects affected by this node.", | ||||||
| "uniqueItems": true, | ||||||
| "items": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refLinkType" | ||||||
|
|
@@ -386,8 +386,8 @@ | |||||
| "target" | ||||||
| ], | ||||||
| "properties": { | ||||||
| "bom-ref": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refType" | ||||||
| "refId": { | ||||||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refIdType" | ||||||
| }, | ||||||
| "name": { | ||||||
| "type": "string", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe out of scope but a good situation to do this: in the docs: make sure all
refare marked a code.Ir if not in scope, create a follow-up ticket from this comment.