Skip to content

Support multiple values where the HCloud API supports it#27

Open
Speedlulu wants to merge 2 commits intoCyclenerd:masterfrom
Speedlulu:lfx/support_multiple_values
Open

Support multiple values where the HCloud API supports it#27
Speedlulu wants to merge 2 commits intoCyclenerd:masterfrom
Speedlulu:lfx/support_multiple_values

Conversation

@Speedlulu
Copy link
Copy Markdown

Changed inputs:

  • network => networks
  • ssh_key => ssh_keys
  • volume => volumes

@Speedlulu Speedlulu force-pushed the lfx/support_multiple_values branch from 0e55b52 to f9e8752 Compare March 24, 2026 14:48
@Cyclenerd
Copy link
Copy Markdown
Owner

This is a breaking change. Can you modify it so that the current inputs still work?

@Speedlulu
Copy link
Copy Markdown
Author

Speedlulu commented Mar 26, 2026

Hi @Cyclenerd,
I've changed it back to using the old input names, but it could be a bit confusing, the names by themselves do not convey that you can input multiple values.
Would you prefer to support both versions (with and without an s at the end) and maybe add a deprecation warning ?

Changed inputs:
* `network` => `networks`
* `ssh_key` => `ssh_keys`
* `volume` => `volumes`
@Speedlulu Speedlulu force-pushed the lfx/support_multiple_values branch from 7a3d103 to af074ef Compare March 26, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants