JitPack Fix: Auto-discover JDK toolchain instead of requiring explicit toolchains.xml#361
Merged
CryptoMorin merged 1 commit intoCryptoMorin:masterfrom Jul 31, 2025
Merged
Conversation
- Fix JitPack builds and streamline collaboration by automatically discovering and selecting a JDK toolchain with JDK version testJava (or above) - Explicit toolchain declaration in ~/.m2/toolchains.xml is no longer required
|
Owner
|
Thank you so much! This really makes it much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes JitPack builds and streamlines collaboration by automatically discovering and selecting a JDK toolchain with JDK version ${testJava} (or above). Explicit toolchain declaration in ~/.m2/toolchains.xml is no longer required for new collaborators, and the automatic selection also prevents tools like JitPack from mysteriously attempting to find a Java 6 path (#329).
Successful JitPack build with this change: https://jitpack.io/com/github/demengc/XSeries/ed391d7c76/build.log
Additional information on automatic discovery of JDK toolchains (new in Apache maven-toolchains-plugin v3.2.0): apache/maven-toolchains-plugin#14 / https://maven.apache.org/plugins/maven-toolchains-plugin/select-jdk-toolchain-mojo.html