Repository navigation
chore(web): Node 26 test fix, Oxlint rules back on, Playwright screenshots - #217
Merged
Merged
Conversation
Bugs5382
marked this pull request as ready for review
November 14, 2026 21:35
Contributor
Author
|
Merging on the owner's approval. CI is green and the branch is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
One PR, one commit per issue.
fix(test): the vitest workers get--no-experimental-webstorage(only where the running Node knows the flag), so Node 26's ownlocalStorageno longer shadows jsdom's. Local runs match CI (Node 22).chore(lint): the rules switched off in the Oxlint move are back on where the code could take them, with the fixes applied (import and object sorting,at(),Response.json, function expressions, and so on).ci(e2e): a Playwright job captures sign-in, fleet overview, fleet, nodes, certificates, issue, revoke, enrolments, approvals and the settings pages (profiles, protocols), light and dark, desktop and mobile (44 images), against the mock build. Saved as artifactconsole-screenshots-pr-<n>on PRs touchingapps/console/**orpackages/ui/**, andconsole-screenshots-<tag>onv*tags. Skipped on drafts, pinned actions, Chromium only, 25 minute timeout. The mock fixtures and the enrolment page now use 192.0.2.0/24 instead of 10.20.x addresses, since these pictures are public.Closes #214
Closes #212
Refs #210 (still to do: run it on the v0.1.0-rc.2 tag, which needs the owner's Release answer, and add the pictures to CryptOS-PKI/website)
Rules kept off on purpose (#212)
unicorn/no-null(492 hits) andunicorn-js/prevent-abbreviations(428): React, DOM and protobuf APIs hand usnulland short names; renaming is churn with no gain.unicorn-js/prefer-https: the fixtures use plain-HTTP CRL/OCSP URLs on purpose.unicorn/number-literal-case: oxfmt lowercases hex, so the two tools fight.unicorn/no-nested-ternary: its fix adds parentheses that oxfmt strips again.unicorn/no-useless-undefined: its fix drops the argumentAsyncGenerator#returnrequires (TS2554).unicorn/prefer-spread: its fix turned a typed-arrayslice()into an array.unicorn/no-array-sort: needs the ES2023 lib; the target is ES2022.unicorn/prefer-module:__dirnameinvite.config.ts.unicorn/prefer-code-point: the code is byte-oriented (charCodeAt), not text.unicorn/prefer-blob-reading-methods:readFileBytesusesFileReaderon purpose (jsdom has noBlob#arrayBuffer).unicorn/prefer-export-from:escrow.tsuses the names it re-exports.unicorn/no-await-expression-member(20) andunicorn/consistent-function-scoping(9): style only, hand edits, left for a follow-up issue.Verification
How this was verified
npx vitest runon Node 26.9 gave 6 failed / 809 passed; after, 815 passed.npm run lint,npm run format:check,tsc(app),npm test(815 + 3 + 249),npm run build, all exit 0. Noeslint-disablecomment sits on a rule that is back on.npx playwright test44 passed locally; revoke and nodes images opened and checked;actionlintclean;npm teststill reports 815, so Vitest does not pick up the e2e files.node --test scripts/*.test.mjsfails one test (path with a space) on main too.