Skip to content

chore(web): Node 26 test fix, Oxlint rules back on, Playwright screenshots - #217

Merged
Bugs5382 merged 3 commits into
mainfrom
chore/214-wave-cryptos-web
Nov 14, 2026
Merged

Bugs5382 merged 3 commits into
mainfrom
chore/214-wave-cryptos-web

Conversation

@Bugs5382

@Bugs5382 Bugs5382 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

What and why

One PR, one commit per issue.

  • fix(test): jsdom localStorage tests fail locally on Node 26 #214 fix(test): the vitest workers get --no-experimental-webstorage (only where the running Node knows the flag), so Node 26's own localStorage no longer shadows jsdom's. Local runs match CI (Node 22).
  • chore(lint): re-enable the lint rules switched off in the Oxlint move #212 chore(lint): the rules switched off in the Oxlint move are back on where the code could take them, with the fixes applied (import and object sorting, at(), Response.json, function expressions, and so on).
  • ci(e2e): capture console screenshots with Playwright in CI #210 ci(e2e): a Playwright job captures sign-in, fleet overview, fleet, nodes, certificates, issue, revoke, enrolments, approvals and the settings pages (profiles, protocols), light and dark, desktop and mobile (44 images), against the mock build. Saved as artifact console-screenshots-pr-<n> on PRs touching apps/console/** or packages/ui/**, and console-screenshots-<tag> on v* tags. Skipped on drafts, pinned actions, Chromium only, 25 minute timeout. The mock fixtures and the enrolment page now use 192.0.2.0/24 instead of 10.20.x addresses, since these pictures are public.

Closes #214
Closes #212
Refs #210 (still to do: run it on the v0.1.0-rc.2 tag, which needs the owner's Release answer, and add the pictures to CryptOS-PKI/website)

Rules kept off on purpose (#212)

  • unicorn/no-null (492 hits) and unicorn-js/prevent-abbreviations (428): React, DOM and protobuf APIs hand us null and short names; renaming is churn with no gain.
  • unicorn-js/prefer-https: the fixtures use plain-HTTP CRL/OCSP URLs on purpose.
  • unicorn/number-literal-case: oxfmt lowercases hex, so the two tools fight.
  • unicorn/no-nested-ternary: its fix adds parentheses that oxfmt strips again.
  • unicorn/no-useless-undefined: its fix drops the argument AsyncGenerator#return requires (TS2554).
  • unicorn/prefer-spread: its fix turned a typed-array slice() into an array.
  • unicorn/no-array-sort: needs the ES2023 lib; the target is ES2022.
  • unicorn/prefer-module: __dirname in vite.config.ts.
  • unicorn/prefer-code-point: the code is byte-oriented (charCodeAt), not text.
  • unicorn/prefer-blob-reading-methods: readFileBytes uses FileReader on purpose (jsdom has no Blob#arrayBuffer).
  • unicorn/prefer-export-from: escrow.ts uses the names it re-exports.
  • unicorn/no-await-expression-member (20) and unicorn/consistent-function-scoping (9): style only, hand edits, left for a follow-up issue.

Verification

  • Lint clean
  • Tests pass
  • Build succeeds
  • Documentation updated (if behavior or API changed): no docs change, CI and test tooling only

How this was verified

… run

Closes #214

Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Closes #212

Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Refs #210

Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
@Bugs5382 Bugs5382 added this to the vNext milestone Nov 14, 2026
@Bugs5382 Bugs5382 added the refactor Internal change / refactor. label Nov 14, 2026
@Bugs5382 Bugs5382 self-assigned this Nov 14, 2026
@Bugs5382
Bugs5382 marked this pull request as ready for review November 14, 2026 21:35
@github-actions github-actions Bot added the skip-changelog Excluded from release notes (chore/ci/test/style). label Nov 14, 2026
@Bugs5382

Copy link
Copy Markdown
Contributor Author

Merging on the owner's approval. CI is green and the branch is clean.

@Bugs5382
Bugs5382 merged commit c7553f4 into main Nov 14, 2026
25 checks passed
@Bugs5382
Bugs5382 deleted the chore/214-wave-cryptos-web branch November 14, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Internal change / refactor. skip-changelog Excluded from release notes (chore/ci/test/style).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(test): jsdom localStorage tests fail locally on Node 26 chore(lint): re-enable the lint rules switched off in the Oxlint move

1 participant