Repository navigation
feat(image): show the running upgrade anchor in image status - #416
Merged
Merged
Conversation
ImageStatus gains upgrade_anchor_subject and upgrade_anchor_sha256, filled from the release certificate the node checks incoming images against. cryptosctl image status prints them in human output and carries them in -o json and -o yaml. Closes #345 Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Bugs5382
marked this pull request as ready for review
November 15, 2026 06:37
This was referenced Nov 15, 2026
Contributor
Author
|
Merging on the owner's approval. CI is green and the branch is clean. |
Contributor
Author
|
Merging on the owner's approval. CI is green and the branch is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
cryptosctl image statusnow shows the upgrade anchor the running node checks incoming images against: its subject and SHA-256. Until now an operator could only prove it indirectly.ImageStatusgainsupgrade_anchor_subject(field 6) andupgrade_anchor_sha256(field 7), filled from the node's release certificate; human output prints both, and-o json/-o yamlcarry them. The proto change is additive (buf breakingpasses).Closes #345
Verification
How this was verified
Tests first:
TestImageStatus_ShowsTheUpgradeAnchor(human, json, yaml) andTestUpgrader_StatusReportsTheUpgradeAnchorfailed before the change and pass after. Also run:task generate(regeneratednode.pb.go),buf lint,buf breakingagainst main,go vet,golangci-lint run, andgo test ./...through the pre-push hook.docs/image-sign.mdgains a line on checking the anchor. The companion docs PR is CryptOS-PKI/website#51; merge together.Before merging: add a closing comment summarizing what was actually done in this PR
(not just the checked boxes).