Repository navigation
fix(chart): default the image tag to v plus appVersion and require the compose version - #232
Merged
Merged
Conversation
…e compose version The release packages the chart with appVersion 0.1.0-rc.1 but publishes the image as v0.1.0-rc.1, so the default image reference never existed. The chart now defaults image.tag to v plus appVersion, compose requires MANAGER_VERSION instead of defaulting to latest (which no rc publishes), and the release's chart job fails if the pushed chart's default image is missing from the registry. Closes #227 Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Compose evaluates the nested required-variable default eagerly, so MANAGER_IMAGE alone still raised the missing MANAGER_VERSION error. An unset version now resolves to a tag that names the fix. Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Contributor
Author
|
Merging on the owner's approval. CI is green and the branch is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The release publishes the image as
ghcr.io/cryptos-pki/cryptos-manager:v0.1.0-rc.1but packages the chart with appVersion0.1.0-rc.1, so the chart's default image never existed. Compose defaulted tolatest, which no rc publishes.image.tagdefaults tovplus appVersion (a leadingvin appVersion is not doubled). An explicitimage.tagstill wins.MANAGER_VERSIONis required (clear error if unset);MANAGER_IMAGEstill overrides. README updated.ghcr.io/cryptos-pki/cryptos-manager:<tag>and exists in the registry.Closes #227
Docs: the Helm page on the website still tells people to set
image.tagby hand; per the issue, update it once this ships (companion website PR to follow).Verification
How this was verified
Rebased on main after #231.
actionlintclean on all workflows;helm package --app-version 0.1.0-rc.1thenhelm templaterenders:v0.1.0-rc.1, and--set image.tag=v9.9.9renders:v9.9.9;helm lintpasses;task cipassed before the rebase and the pre-push gate passed on push. Not run locally: docker compose (no plugin here; ci-image covers it) and the release job (runs on a tag).