Skip to content

fix(chart): default the image tag to v plus appVersion and require the compose version - #232

Merged
Bugs5382 merged 2 commits into
mainfrom
fix/227-chart-default-image-tag
Nov 14, 2026
Merged

Bugs5382 merged 2 commits into
mainfrom
fix/227-chart-default-image-tag

Conversation

@Bugs5382

Copy link
Copy Markdown
Contributor

What and why

The release publishes the image as ghcr.io/cryptos-pki/cryptos-manager:v0.1.0-rc.1 but packages the chart with appVersion 0.1.0-rc.1, so the chart's default image never existed. Compose defaulted to latest, which no rc publishes.

  • Chart: image.tag defaults to v plus appVersion (a leading v in appVersion is not doubled). An explicit image.tag still wins.
  • Compose: MANAGER_VERSION is required (clear error if unset); MANAGER_IMAGE still overrides. README updated.
  • Release: the chart job renders the pushed chart from the registry and fails unless its default image is ghcr.io/cryptos-pki/cryptos-manager:<tag> and exists in the registry.
  • CI: chart-lint packages like the release and asserts the default and the override; ci-image asserts compose fails without a version and renders with either variable.

Closes #227

Docs: the Helm page on the website still tells people to set image.tag by hand; per the issue, update it once this ships (companion website PR to follow).

Verification

  • Lint clean
  • Tests pass
  • Build succeeds
  • Documentation updated (README; website Helm page after release)

How this was verified

Rebased on main after #231. actionlint clean on all workflows; helm package --app-version 0.1.0-rc.1 then helm template renders :v0.1.0-rc.1, and --set image.tag=v9.9.9 renders :v9.9.9; helm lint passes; task ci passed before the rebase and the pre-push gate passed on push. Not run locally: docker compose (no plugin here; ci-image covers it) and the release job (runs on a tag).

…e compose version

The release packages the chart with appVersion 0.1.0-rc.1 but publishes the
image as v0.1.0-rc.1, so the default image reference never existed. The
chart now defaults image.tag to v plus appVersion, compose requires
MANAGER_VERSION instead of defaulting to latest (which no rc publishes), and
the release's chart job fails if the pushed chart's default image is missing
from the registry.

Closes #227

Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
@Bugs5382 Bugs5382 added this to the v0.1.0 milestone Nov 14, 2026
@Bugs5382 Bugs5382 added the bug Something isn't working. label Nov 14, 2026
@Bugs5382 Bugs5382 self-assigned this Nov 14, 2026
Compose evaluates the nested required-variable default eagerly, so
MANAGER_IMAGE alone still raised the missing MANAGER_VERSION error. An
unset version now resolves to a tag that names the fix.

Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
@github-actions github-actions Bot added the fix Bug fix (fix). Patch. label Nov 14, 2026
@Bugs5382

Copy link
Copy Markdown
Contributor Author

Merging on the owner's approval. CI is green and the branch is clean.

@Bugs5382
Bugs5382 merged commit 2b1f522 into main Nov 14, 2026
12 checks passed
@Bugs5382
Bugs5382 deleted the fix/227-chart-default-image-tag branch November 14, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. fix Bug fix (fix). Patch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(chart): default image tag doesn't match the published image

1 participant