Repository navigation
feat: align GitHub documentation with LocalSetup visual identity - #113
Conversation
Release-Type: none
Release-Type: none
Release-Type: none
Release-Type: none
github-actions
Bot
added
area/docs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10a787c5f6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { | ||
| "schema_version": 1, | ||
| "version": "5.7.0", | ||
| "source_commit": "9a582770215b4322ac4e2b176ea5a2d4bb9012e4", |
There was a problem hiding this comment.
9a582770... is on a different lineage from this commit (its merge base with 7e830ab is 51fbdf7, and it is not an ancestor). release-docs check explicitly rejects such records with source_not_ancestor, so this version-bump commit cannot pass the release documentation gate. Regenerate or rebind the record to a source commit in the final candidate's ancestry.
AGENTS.md reference: AGENTS.md:L45-L50
Useful? React with 👍 / 👎.
| def render(*, check: bool, social_output: Path | None) -> None: | ||
| for name, expected in FONT_HASHES.items(): | ||
| actual = hashlib.sha256((BRAND / "fonts" / name).read_bytes()).hexdigest() | ||
| if actual != expected: | ||
| raise RuntimeError(f"Font hash mismatch: {name}") |
There was a problem hiding this comment.
This new direct-execution tool contains the renderer's dependency validation, rendering, and write behavior in ls/tools/ rather than acting as the required thin entrypoint. Move the implementation into a dedicated ls/core package and leave this file to resolve the checkout and invoke its CLI, matching the repository's required Python-tooling architecture.
AGENTS.md reference: AGENTS.md:L70-L70
Useful? React with 👍 / 👎.
| os.environ["FONTCONFIG_FILE"] = str(config) | ||
| for weight, style in (("regular", "Regular"), ("demibold", "SemiBold")): | ||
| resolved = subprocess.run( | ||
| ["fc-match", "-f", "%{family}|%{style}|%{file}", f"JetBrains Mono:weight={weight}"], | ||
| check=True, capture_output=True, text=True, |
There was a problem hiding this comment.
On a normal macOS checkout, fc-match and /etc/fonts/fonts.conf are not available, so the documented graphics renderer fails with FileNotFoundError before it can render or run --check; minimal Linux environments without Fontconfig fail similarly. Use a cross-platform bundled-font validation/rendering path, or provide and document a supported platform-specific renderer, so this repository tool remains portable.
AGENTS.md reference: AGENTS.md:L94-L94
Useful? React with 👍 / 👎.
1 participant
Summary
<picture>consumers, and teach the documentation inventory to count darksrcsetimages.Validation
LOCALSETUP_TEST_WORKERS=3override, six from the SDK receipt before it was refreshed (all 14 SDK tests now pass), and the remainder came from ignored broken local adapter symlinks copied into temporary test repositories. Clean GitHub CI is the final full-suite gate.Compatibility
The
localsetupframework command,lscli, and existing light image URLs remain unchanged. Nerd Font glyphs are documented as an optional future AstroSite profile; the shipped documentation graphics use the pinned official JetBrains Mono files.