Skip to content

security(star-rating): authorize the /o?method=star ratings read #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ar2rsawseen wants to merge 1 commit into
base: master
Choose a base branch
from
+70 −63
Open

security(star-rating): authorize the /o?method=star ratings read #7955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Enterprise Fixes:
- [data-manager] Fixed editing an event whose key contains `&` creating undeletable duplicate rows in the events table

Security Fixes:
- [star-rating] The `/o?method=star` ratings read now requires star-rating read access to the application it is asked about. It previously performed no authorization, so the platform and application-version combinations that had received ratings could be read for any application by a caller with no account, token or session
- [hooks] Internal event hooks are now scoped to the apps the hook belongs to: app creation is a global-admin-only event, and remote-config, cohort, alert and hook-chaining events are only delivered when the event's app is one the hook is scoped to
- [compliance-hub] The consents table now returns a fixed set of fields; a projection supplied on the request is no longer used to widen the response beyond the consent columns
- [dashboards] Widgets are no longer copied when the copying user has no access to the apps they reference, and widget app ids are validated on widget create and update
Expand Down
132 changes: 69 additions & 63 deletions plugins/star-rating/api/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1577,79 +1577,85 @@ function uploadFile(myfile, id, callback) {
plugins.register('/o', function(ob) {
var params = ob.params;
if (params.qstring.method === 'star') {
if (params.qstring.period) {
//check if period comes from datapicker
if (params.qstring.period.indexOf(",") !== -1) {
try {
params.qstring.period = JSON.parse(params.qstring.period);
}
catch (SyntaxError) {
common.returnMessage(params, 400, 'Bad request parameter: period');
return true;
}
}
else {
switch (params.qstring.period) {
case "prevMonth":
case "month":
case "day":
case "yesterday":
case "hour":
break;
default:
if (!/([0-9]+)days/.test(params.qstring.period)) {
//this read is app scoped: require the caller to hold star-rating
//read access on app_id, the same check the sibling reads in this
//file apply. Authorize before validating parameters so that an
//unauthorized caller cannot probe the endpoint.
validateRead(params, FEATURE_NAME, function() {
if (params.qstring.period) {
//check if period comes from datapicker
if (params.qstring.period.indexOf(",") !== -1) {
try {
params.qstring.period = JSON.parse(params.qstring.period);
}
catch (SyntaxError) {
common.returnMessage(params, 400, 'Bad request parameter: period');
return true;
}
break;
}
else {
switch (params.qstring.period) {
case "prevMonth":
case "month":
case "day":
case "yesterday":
case "hour":
break;
default:
if (!/([0-9]+)days/.test(params.qstring.period)) {
common.returnMessage(params, 400, 'Bad request parameter: period');
return true;
}
break;
}
}
}
}
else {
common.returnMessage(params, 400, 'Missing request parameter: period');
return true;
}
countlyCommon.setPeriod(params.qstring.period, true);
var periodObj = countlyCommon.periodObj;
var collectionName = crypto.createHash('sha1').update('[CLY]_star_rating' + params.qstring.app_id).digest('hex');
var id_prefix = params.qstring.app_id + "_" + collectionName + "_";
var documents = [];
for (var i = 0; i < periodObj.reqZeroDbDateIds.length; i++) {
documents.push(id_prefix + "no-segment_" + periodObj.reqZeroDbDateIds[i]);
for (var m = 0; m < common.base64.length; m++) {
documents.push(id_prefix + "no-segment_" + periodObj.reqZeroDbDateIds[i] + "_" + common.base64[m]);
else {
common.returnMessage(params, 400, 'Missing request parameter: period');
return true;
}
}
common.db.collection("events_data").find({
'_id': {
$in: documents
countlyCommon.setPeriod(params.qstring.period, true);
var periodObj = countlyCommon.periodObj;
var collectionName = crypto.createHash('sha1').update('[CLY]_star_rating' + params.qstring.app_id).digest('hex');
var id_prefix = params.qstring.app_id + "_" + collectionName + "_";
var documents = [];
for (var i = 0; i < periodObj.reqZeroDbDateIds.length; i++) {
documents.push(id_prefix + "no-segment_" + periodObj.reqZeroDbDateIds[i]);
for (var m = 0; m < common.base64.length; m++) {
documents.push(id_prefix + "no-segment_" + periodObj.reqZeroDbDateIds[i] + "_" + common.base64[m]);
}
}
}).toArray(function(err, docs) {
if (!err) {
var result = {};
docs.forEach(function(doc) {
if (!doc.meta) {
doc.meta = {};
}
if (!doc.meta.platform_version_rate) {
doc.meta.platform_version_rate = [];
}
if (doc.meta_v2 && doc.meta_v2.platform_version_rate) {
common.arrayAddUniq(doc.meta.platform_version_rate, Object.keys(doc.meta_v2.platform_version_rate));
}
doc.meta.platform_version_rate.forEach(function(item) {
var data = item.split('**');
if (result[data[0]] === undefined) {
result[data[0]] = [];
common.db.collection("events_data").find({
'_id': {
$in: documents
}
}).toArray(function(err, docs) {
if (!err) {
var result = {};
docs.forEach(function(doc) {
if (!doc.meta) {
doc.meta = {};
}
if (!doc.meta.platform_version_rate) {
doc.meta.platform_version_rate = [];
}
if (result[data[0]].indexOf(data[1]) === -1) {
result[data[0]].push(data[1]);
if (doc.meta_v2 && doc.meta_v2.platform_version_rate) {
common.arrayAddUniq(doc.meta.platform_version_rate, Object.keys(doc.meta_v2.platform_version_rate));
}
doc.meta.platform_version_rate.forEach(function(item) {
var data = item.split('**');
if (result[data[0]] === undefined) {
result[data[0]] = [];
}
if (result[data[0]].indexOf(data[1]) === -1) {
result[data[0]].push(data[1]);
}
});
});
});
common.returnOutput(params, result);
return true;
}
common.returnOutput(params, result);
return true;
}
});
});
return true;
}
Expand Down
Loading