Skip to content

[fix][push] check audience filter operators on the estimate endpoint #7947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ar2rsawseen wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

[fix][push] check audience filter operators on the estimate endpoint #7947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions plugins/push/api/api-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,17 @@ module.exports.estimate = async params => {
return true;
}

// estimate() builds the audience aggregation from data.filter directly, without going
// through validate(), so apply the same operator check validate() runs for
// test/create/update. Without it, filter.user / filter.drill reach the $match stage of
// an aggregation over app_users unchecked, so a server-side-JS operator such as
// $function (including nested inside $expr) would execute in the database.
let badOp = common.findUnsafeMongoOperator(data.filter.user) || common.findUnsafeMongoOperator(data.filter.drill);
if (badOp) {
common.returnMessage(params, 400, common.unsafeQueryError(badOp));
return true;
}

// Cross-app guard. validateRead only checks the caller's permission against
// params.qstring.app_id, while the body's "app" field selects which app's
// push audience is counted. Without this binding a user with push:read on
Expand Down
Loading